Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling revise sometimes fails with a BoundsError inside process_user_callbacks #874

Open
Octogonapus opened this issue Dec 22, 2024 · 1 comment

Comments

@Octogonapus
Copy link

I am calling revise() from my program to watch for changes and re-run tests, which I think is causing it to run from multiple threads. It looks like revise() isn't thread-safe (occasional exception below) but I wanted to confirm.

BoundsError: attempt to access 16-element Vector{Any} at index [0]
    Stacktrace:
     [1] _deleteend!
       @ ./array.jl:1081 [inlined]
     [2] empty!
       @ ./array.jl:1842 [inlined]
     [3] empty!(h::Dict{Any, Nothing})
       @ Base ./dict.jl:249
     [4] empty!
       @ ./set.jl:121 [inlined]
     [5] process_user_callbacks!(keys::Set{Any}; throw::Bool)
       @ Revise ~/.julia/packages/Revise/uvGMC/src/callbacks.jl:126
     [6] process_user_callbacks! (repeats 2 times)
       @ ~/.julia/packages/Revise/uvGMC/src/callbacks.jl:112 [inlined]
     [7] revise(; throw::Bool)
       @ Revise ~/.julia/packages/Revise/uvGMC/src/packagedef.jl:845
     [8] revise()
       @ Revise ~/.julia/packages/Revise/uvGMC/src/packagedef.jl:750

Revise v3.6.4
Julia 1.10.5

@timholy
Copy link
Owner

timholy commented Dec 28, 2024

It should be, see, e.g., #846. If you can provide a MWE I can look in greater detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants