[CI] Update MACA toolkit version from 3.6 into 3.7#110
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates the CI workflow's MACA job: it selects ChangesMACA Toolkit and dependency pin
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 291: The pip install line currently pins flash_linear_attention to the
plain public version "flash_linear_attention==0.4.0" which doesn't exist on the
metax index; update that package spec in the uv pip install command to the
metax-specific wheel variant (e.g.
"flash_linear_attention==0.4.0+metax3.7.X.YtorchZ.W") that matches your MACA 3.7
toolkit and Torch version so pip can resolve it, keeping the same index URL and
--trusted-host flags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| elif [[ "${{ matrix.runner.toolkit }}" == *"MACA"* ]]; then | ||
| uv pip install -v -r requirements-test-maca.txt | ||
| uv pip install -v --no-deps --python-version 3.10.0 flash_linear_attention==0.4.0+metax3.5.3.9torch2.8 -i https://repos.metax-tech.com/r/maca-pypi/simple --trusted-host repos.metax-tech.com | ||
| uv pip install -v --no-deps --python-version 3.10.0 flash_linear_attention==0.4.0 -i https://repos.metax-tech.com/r/maca-pypi/simple --trusted-host repos.metax-tech.com |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check available flash_linear_attention versions in the MACA repository
# Query the repository for available versions
curl -s "https://repos.metax-tech.com/r/maca-pypi/simple/flash-linear-attention/" 2>/dev/null | \
grep -oP 'flash[_-]linear[_-]attention-[^"]+\.whl' | \
grep '0\.4\.0' | \
head -20
# If curl fails, note that manual verification is needed
if [ $? -ne 0 ]; then
echo "Note: Unable to query repository. Manual verification required."
fiRepository: tile-ai/tilelang-metax
Length of output: 1654
🏁 Script executed:
#!/bin/bash
set -euo pipefail
base="https://repos.metax-tech.com/r/maca-pypi/simple/flash-linear-attention/"
page="$(curl -fsSL "$base")"
echo "== wheels matching exact version 0.4.0 (no + local segment) =="
# Example wheel names: flash_linear_attention-0.4.0-cp310-...whl
echo "$page" | rg -o 'flash[_-]linear[_-]attention-0\.4\.0-[^"]+\.whl' | sort -u | head -50
echo
echo "== wheels matching 0.4.0+metax3.7 local versions =="
echo "$page" | rg -o 'flash[_-]linear[_-]attention-0\.4\.0\+metax3\.7[^"]+\.whl' | sort -u | head -50
echo
echo "== any exact 0.4.0 references on the page =="
echo "$page" | rg -n 'flash[_-]linear[_-]attention-0\.4\.0' | head -50Repository: tile-ai/tilelang-metax
Length of output: 129
🏁 Script executed:
#!/bin/bash
set -uo pipefail
base="https://repos.metax-tech.com/r/maca-pypi/simple/flash-linear-attention/"
page="$(curl -fsSL "$base" 2>/dev/null || true)"
if [[ -z "${page}" ]]; then
echo "curl returned empty page (or failed)."
exit 0
fi
echo "== Sample matches from index page =="
echo "$page" | rg -o 'flash[_-]linear[_-]attention-[^"]+\.whl' | head -50
echo
echo "== Unique versions from wheel filenames =="
echo "$page" | rg -o 'flash[_-]linear[_-]attention-([^"]+)\.whl' | sed -E 's/flash[_-]linear[_-]attention-//' | sort -u
echo
echo "== Any exact 0.4.0 (public) wheel link? =="
echo "$page" | rg -n 'flash[_-]linear[_-]attention-0\.4\.0[^+./"]*\.whl' || trueRepository: tile-ai/tilelang-metax
Length of output: 4408
Fix flash_linear_attention pin for MACA 3.7 (avoid installing non-existent public 0.4.0)
The metax index for flash-linear-attention provides wheels only for local versions like flash_linear_attention-0.4.0+metax3.7.0.7torch2.8 / 0.4.0+metax3.7.1.3torch2.8 / 0.4.0+metax3.7.2.0torch2.8 (and torch2.6 variants), and shows no wheel entries for the plain public flash_linear_attention-0.4.0 (without the +metax... suffix). Pinning to flash_linear_attention==0.4.0 at .github/workflows/ci.yml:291 may fail to resolve.
Update the requirement to the appropriate flash_linear_attention==0.4.0+metax3.7...torch... variant matching your MACA 3.7 toolkit and torch version.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml at line 291, The pip install line currently pins
flash_linear_attention to the plain public version
"flash_linear_attention==0.4.0" which doesn't exist on the metax index; update
that package spec in the uv pip install command to the metax-specific wheel
variant (e.g. "flash_linear_attention==0.4.0+metax3.7.X.YtorchZ.W") that matches
your MACA 3.7 toolkit and Torch version so pip can resolve it, keeping the same
index URL and --trusted-host flags.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/ci.yml (1)
291-291:⚠️ Potential issue | 🟠 Major | ⚡ Quick winThis issue was already flagged in a previous review and remains unaddressed.
The metax index for
flash_linear_attentionprovides only local versions like0.4.0+metax3.7.X.YtorchZ.W, not the plain public0.4.0. The current pin may fail to resolve. Update the requirement to the appropriate metax-specific wheel variant matching MACA 3.7 and torch version, following the pattern used inpr-regression-test-bot.yml.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml at line 291, The CI pip install line currently pins flash_linear_attention to the public version "flash_linear_attention==0.4.0" which the metax index does not provide; change that package spec to the metax-specific wheel variant that matches our MACA 3.7 and torch version (the +metax3.7...+torch... suffix pattern), mirroring the pattern used in pr-regression-test-bot.yml: replace "flash_linear_attention==0.4.0" with the exact metax-specific wheel name (e.g. flash_linear_attention==0.4.0+metax3.7.X.YtorchZ.W) that corresponds to the pipeline's MACA and torch versions so pip can resolve from the metax index and keep the rest of the pip install command (index URL and --trusted-host) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In @.github/workflows/ci.yml:
- Line 291: The CI pip install line currently pins flash_linear_attention to the
public version "flash_linear_attention==0.4.0" which the metax index does not
provide; change that package spec to the metax-specific wheel variant that
matches our MACA 3.7 and torch version (the +metax3.7...+torch... suffix
pattern), mirroring the pattern used in pr-regression-test-bot.yml: replace
"flash_linear_attention==0.4.0" with the exact metax-specific wheel name (e.g.
flash_linear_attention==0.4.0+metax3.7.X.YtorchZ.W) that corresponds to the
pipeline's MACA and torch versions so pip can resolve from the metax index and
keep the rest of the pip install command (index URL and --trusted-host)
unchanged.
1 participant
Summary by CodeRabbit