Skip to content

Hard-deprecate trunc_mat() #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krlmlr opened this issue Oct 18, 2021 · 7 comments · May be fixed by #1623
Open

Hard-deprecate trunc_mat() #960

krlmlr opened this issue Oct 18, 2021 · 7 comments · May be fixed by #1623
Labels
help wanted ❤️ we'd love your help!
Milestone
4.0.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Oct 18, 2021

For r-lib/pillar#272.
@krlmlr krlmlr added this to the 3.1.6 milestone Oct 18, 2021
@krlmlr krlmlr changed the title Remove colonnade() reexport Remove use of colonnade() Oct 25, 2021
@krlmlr krlmlr modified the milestones: 3.1.6, 4.0.0 Oct 25, 2021
@krlmlr krlmlr changed the title Remove use of colonnade() Hard-deprecate trunc_mat() to remove use of colonnade() Oct 25, 2021
@krlmlr
Copy link
Member Author

krlmlr commented Dec 25, 2021

Needs tidyverse/dplyr#6141.

@krlmlr
Copy link
Member Author

krlmlr commented Jan 2, 2022

Needs tidyverse/dplyr#6059.

@krlmlr
Copy link
Member Author

krlmlr commented Feb 23, 2023

Needs jacob-long/panelr#55.

@krlmlr krlmlr added the help wanted ❤️ we'd love your help! label Mar 18, 2025
@krlmlr
Copy link
Member Author

krlmlr commented Mar 18, 2025

colonnade() now hard-deprecated in pillar.

@krlmlr krlmlr changed the title Hard-deprecate trunc_mat() to remove use of colonnade() Hard-deprecate trunc_mat() Mar 18, 2025
@moodymudskipper
Copy link

The 'tibble' package uses the 'lifecycle' package to handle the deprecation cycle.

From ? deprecate_soft :

  • deprecate_soft() warns only if the deprecated function is called directly, i.e. a user is calling a function they wrote in the global environment or a developer is calling it in their package. It does not warn when called indirectly, i.e. the deprecation comes from code that you don't control.
  • deprecate_warn() warns unconditionally.
  • deprecate_stop() fails unconditionally.`

trunc_mat() contains a calls to deprecate_soft(), we want deprecate_warn() instead (+ Update in the NEWS).

@moodymudskipper
Copy link

@krlmlr do we want deprecate_warn()or deprecate_stop() I'm not sure now

@krlmlr
Copy link
Member Author

krlmlr commented Mar 26, 2025

Responded offline, stop() is better. The NEWS update is handled by fledge here.

@andreranza andreranza linked a pull request Mar 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted ❤️ we'd love your help!
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

feat: Hard deprecate trunc_mat() andreranza/tibble
2 participants
@krlmlr @moodymudskipper