Skip to content

Commit ce6926f

Browse files
committed
Remove TODOs
1 parent fb6ee6d commit ce6926f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

R/summarise.R

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ summarise.data.frame <- function(.data, ..., .by = NULL, .groups = NULL) {
152152

153153
#' @export
154154
summarise.grouped_df <- function(.data, ..., .by = NULL, .groups = NULL) {
155-
# TODO: Is it right to even expose `.by` here? It lets us catch errors.
156155
# Will always error if `.by != NULL` b/c you can't use it with grouped/rowwise dfs.
157156
by <- compute_by({{ .by }}, .data, by_arg = ".by", data_arg = ".data")
158157

@@ -199,7 +198,6 @@ summarise.grouped_df <- function(.data, ..., .by = NULL, .groups = NULL) {
199198

200199
#' @export
201200
summarise.rowwise_df <- function(.data, ..., .by = NULL, .groups = NULL) {
202-
# TODO: Is it right to even expose `.by` here? It lets us catch errors.
203201
# Will always error if `.by != NULL` b/c you can't use it with grouped/rowwise dfs.
204202
by <- compute_by({{ .by }}, .data, by_arg = ".by", data_arg = ".data")
205203

0 commit comments

Comments
 (0)