Skip to content

Commit 02b3fff

Browse files
authored
choose_eval_time() needs a metric that's not NULL (#146)
1 parent 34b673f commit 02b3fff

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

R/rank_results.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ rank_results <- function(x, rank_metric = NULL, eval_time = NULL, select_best =
3737
tune::check_metric_in_tune_results(tibble::as_tibble(met_set), rank_metric)
3838
}
3939

40-
eval_time <- tune::choose_eval_time(result_1, rank_metric, eval_time)
41-
4240
metric_info <- pick_metric(x, rank_metric)
4341
metric <- metric_info$metric
4442
direction <- metric_info$direction
4543
wflow_info <- dplyr::bind_cols(purrr::map_dfr(x$info, I), dplyr::select(x, wflow_id))
4644

45+
eval_time <- tune::choose_eval_time(result_1, metric, eval_time)
46+
4747
results <- collect_metrics(x) %>%
4848
dplyr::select(wflow_id, .config, .metric, mean, std_err, n,
4949
dplyr::any_of(".eval_time")) %>%

0 commit comments

Comments
 (0)