Apply suggestions from code review

Co-authored-by: Hannah Frick <[email protected]>

Author: topepo

R/aaa_models.R

@@ -244,7 +244,7 @@ check_spec_mode_engine_val <- function(cls, eng, mode) {
 check_mode_with_no_engine <- function(cls, mode) {
   spec_modes <- get_from_env(paste0(cls, "_modes"))
   if (!(mode %in% spec_modes)) {
-    stop_incompatible_mode(spec_modes, cls)
+    stop_incompatible_mode(spec_modes, cls = cls)
   }
 }
 

R/arguments.R

@@ -79,7 +79,7 @@ set_mode <- function(object, mode) {
   cls <- class(object)[1]
   if (rlang::is_missing(mode)) {
     spec_modes <- rlang::env_get(get_model_env(), paste0(cls, "_modes"))
-    stop_incompatible_mode(spec_modes, cls)
+    stop_incompatible_mode(spec_modes, cls = cls)
   }
   check_spec_mode_engine_val(cls, object$engine, mode)
   object$mode <- mode

tests/testthat/test_args_and_modes.R

@@ -85,12 +85,12 @@ test_that("unavailable modes for an engine and vice-versa", {
 
   expect_error(
     proportional_hazards() %>% set_mode("regression"),
-    "Available modes for engine proportional_hazards"
+    "Available modes for model type proportional_hazards"
   )
 
   expect_error(
     linear_reg() %>% set_mode(),
-    "Available modes for engine linear_reg"
+    "Available modes for model type linear_reg"
   )
 
   expect_error(
@@ -105,4 +105,3 @@ test_that("unavailable modes for an engine and vice-versa", {
 })
 
 
-