Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with warnings in tests #56

Closed
hfrick opened this issue Feb 22, 2022 · 2 comments
Closed

deal with warnings in tests #56

hfrick opened this issue Feb 22, 2022 · 2 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@hfrick
Copy link
Member

hfrick commented Feb 22, 2022

I'm seeing a lot of warnings in the tests of the type below, would be nice to clean up 🧹

Warning (test-mars.R:72:3): check model reduction
non-uniform 'Rounding' sampler used
Backtrace:
  1. baguette::bagger(...)
       at test-mars.R:72:2
 24. dplyr `<fn>`(`<smplWrnn>`)
 25. dplyr:::check_muffled_warning(w)
 26. base::withRestarts(...)
 27. base withOneRestart(expr, restarts[[1L]])
 28. base doWithOneRestart(return(expr), restart)
@hfrick hfrick added the upkeep maintenance, infrastructure, and similar label Feb 22, 2022
@juliasilge
Copy link
Member

We also see quite a lot of warnings about the now-deprecated fit_control():

Warning (test-validation.R:153:3): model failures inputs
`fit_control()` was deprecated in parsnip 0.1.8.
Please use `control_parsnip()` instead.
Backtrace:
  1. testthat::expect_error(...)
       at test-validation.R:153:2
 17. furrr iter(...)
 18. furrr:::furrr_map2_template(...)
 19. furrr:::furrr_template(...)
 20. future::future(...)
 22. future:::run.Future(future)
 24. future:::run.UniprocessFuture(future)
 25. [ base::eval(...) ] with 1 more call
 37. [ base::eval(...) ] with 1 more call
 40. purrr `<fn>`(...)
 41. baguette .f(.x[[i]], .y[[i]], ...)
 42. baguette ...furrr_fn(...)
 45. baguette .fn(split, ...)
 46. parsnip::fit_control(catch = TRUE)

@topepo
Copy link
Member

topepo commented Jan 28, 2025

These do not appear to surface any more. The round issue has gone away since R versions in our range of supported releases have consistent RNG settings

@topepo topepo closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

3 participants