Fix a couple of issues with the package upload page

[VilppeRiskidev]

• Errors are now displayed (as a toast) if the upload fails
• Clicking on Remove (uploaded package) button no longer opens the file select
• Removed a lot of commented code

[coderabbitai]

Walkthrough

This change refactors the upload component to remove external uploader hook dependencies and consolidate upload control logic. The modification shifts from manual upload triggering to automatic initiation upon file selection via useEffect. Error handling is enhanced with try/catch wrapping and toast notifications. The UI is streamlined by removing legacy components and the manual upload button, while preserving submission status messaging. The component's public interface remains unchanged.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main changes: fixing issues with error handling, Remove button behavior, and code cleanup in the upload page.
Description check	✅ Passed	The description clearly relates to the changeset, covering the three key improvements: error toast display, Remove button fix, and commented code removal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch upload-package-fixes

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c3ed22 and ad8ef60.

📒 Files selected for processing (1)

• apps/cyberstorm-remix/app/upload/upload.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Generate visual diffs
• GitHub Check: Test

🔇 Additional comments (2)

apps/cyberstorm-remix/app/upload/upload.tsx (2)

156-168: LGTM! Clean error handling.

The try/catch properly handles upload failures, provides user feedback via toast, and cleans up state. The error message handling is defensive.

---

455-457: LGTM! Correctly prevents file dialog.

The stopPropagation and preventDefault properly prevent the click from triggering the parent DnD input's file selection. This directly addresses the stated PR objective.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.87%. Comparing base (3c3ed22) to head (ad8ef60).

Files with missing lines	Patch %	Lines
apps/cyberstorm-remix/app/upload/upload.tsx	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #1611      +/-   ##
=========================================
- Coverage    9.88%   9.87%   -0.01%     
=========================================
  Files         310     310              
  Lines       22497   22508      +11     
  Branches      406     406              
=========================================
  Hits         2223    2223              
- Misses      20274   20285      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.