Use Team.create in create_team service

Utilize Team.create() in create_team service instead of using
Team.objects.create(). This will create Team and Namespace as required
and call the necesseary validation method in the model.

Remove redundant error checks in the service as there is no need for
double checking.

Update imports in team forms.py.

Refs. TS-2426

Author: Roffenlund

django/thunderstore/api/cyberstorm/services/team.py

@@ -1,10 +1,9 @@
-from django.core.exceptions import ValidationError
 from django.db import transaction
 
 from thunderstore.account.models import ServiceAccount
 from thunderstore.core.exceptions import PermissionValidationError
 from thunderstore.core.types import UserType
-from thunderstore.repository.models import Namespace, Team, TeamMember
+from thunderstore.repository.models import Team, TeamMember
 from thunderstore.repository.models.team import TeamMemberRole
 
 
@@ -21,12 +20,8 @@ def create_team(agent: UserType, team_name: str) -> Team:
         raise PermissionValidationError("Must be authenticated to create teams")
     if getattr(agent, "service_account", None) is not None:
         raise PermissionValidationError("Service accounts cannot create teams")
-    if Team.objects.filter(name__iexact=team_name).exists():
-        raise ValidationError("Team with this Name already exists")
-    if Namespace.objects.filter(name__iexact=team_name).exists():
-        raise ValidationError("Team with this Namespace already exists")
 
-    team = Team.objects.create(name=team_name)
+    team = Team.create(name=team_name)
     team.add_member(user=agent, role=TeamMemberRole.owner)
     return team
 

django/thunderstore/repository/forms/team.py

@@ -3,6 +3,7 @@
 from django import forms
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ObjectDoesNotExist, ValidationError
+from django.db import transaction
 
 from thunderstore.api.cyberstorm.services.team import (
     create_team,
@@ -12,7 +13,7 @@
     update_team_member,
 )
 from thunderstore.core.types import UserType
-from thunderstore.repository.models import Team, TeamMember, TeamMemberRole, transaction
+from thunderstore.repository.models import Team, TeamMember, TeamMemberRole
 from thunderstore.repository.validators import PackageReferenceComponentValidator
 
 User = get_user_model()