Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why attn2 is always set to False. #17

Open
YihengBrianWu opened this issue Feb 10, 2025 · 1 comment
Open

Why attn2 is always set to False. #17

YihengBrianWu opened this issue Feb 10, 2025 · 1 comment

Comments

@YihengBrianWu
Copy link

YihengBrianWu commented Feb 10, 2025

Thanks for the amazing work.
I have a question why attn2 is always False in ditFastAttn implementation.
Compressing attn2 will decrease the quality of result?
https://github.com/thu-nics/DiTFastAttn/blob/main/dit_fast_attention.py#L142

@YihengBrianWu
Copy link
Author

Furthermore, Is DitFastAttn available in multi-cards scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant