diff --git a/src/embed/conversation.spec.ts b/src/embed/conversation.spec.ts index 99207694..104c2551 100644 --- a/src/embed/conversation.spec.ts +++ b/src/embed/conversation.spec.ts @@ -148,7 +148,7 @@ describe('ConversationEmbed', () => { searchQuery: 'searchQuery', }, dataPanelV2: true, - hiddenActions: [Action.InConversationTraining] + hiddenActions: [Action.InConversationTraining], }; const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig); @@ -282,6 +282,40 @@ describe('ConversationEmbed', () => { ); }); + it('should render the conversation embed with past conversations sidebar enabled', async () => { + const viewConfig: SpotterEmbedViewConfig = { + worksheetId: 'worksheetId', + searchOptions: { + searchQuery: 'searchQuery', + }, + enablePastConversationsSidebar: true, + }; + + const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig); + await conversationEmbed.render(); + expectUrlMatchesWithParams( + getIFrameSrc(), + `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&enablePastConversationsSidebar=true#/embed/insights/conv-assist?worksheet=worksheetId&query=searchQuery`, + ); + }); + + it('should render the conversation embed with past conversations sidebar disabled', async () => { + const viewConfig: SpotterEmbedViewConfig = { + worksheetId: 'worksheetId', + searchOptions: { + searchQuery: 'searchQuery', + }, + enablePastConversationsSidebar: false, + }; + + const conversationEmbed = new SpotterEmbed(getRootEl(), viewConfig); + await conversationEmbed.render(); + expectUrlMatchesWithParams( + getIFrameSrc(), + `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true&enablePastConversationsSidebar=false#/embed/insights/conv-assist?worksheet=worksheetId&query=searchQuery`, + ); + }); + it('should ensure deprecated ConversationEmbed class maintains same functionality as SpotterEmbed', async () => { const viewConfig: SpotterEmbedViewConfig = { worksheetId: 'worksheetId', diff --git a/src/embed/conversation.ts b/src/embed/conversation.ts index 139ba205..1fc0d1d2 100644 --- a/src/embed/conversation.ts +++ b/src/embed/conversation.ts @@ -164,6 +164,22 @@ export interface SpotterEmbedViewConfig extends Omit