Remove multiple primary handling logic from SDK (#308)

Author: adityamittal3107

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@thoughtspot/visual-embed-sdk",
-    "version": "1.40.2",
+    "version": "1.40.3",
     "description": "ThoughtSpot Embed SDK",
     "module": "lib/src/index.js",
     "main": "dist/tsembed.js",

src/errors.ts

@@ -25,7 +25,6 @@ export const CUSTOM_ACTIONS_ERROR_MESSAGE = {
     MISSING_REQUIRED_FIELDS: (id: string, missingFields: string[]) => `Custom Action Validation Error for '${id}': Missing required fields: ${missingFields.join(', ')}`,
     UNSUPPORTED_TARGET: (id: string, targetType: string) => `Custom Action Validation Error for '${id}': Target type '${targetType}' is not supported`,
     INVALID_POSITION: (position: string, targetType: string, supportedPositions: string) => `Position '${position}' is not supported for ${targetType.toLowerCase()}-level custom actions. Supported positions: ${supportedPositions}`,
-    MULTIPLE_PRIMARY_ACTIONS: (targetType: string, existingName: string, newName: string) => `Multiple primary actions found for ${targetType.toLowerCase()}-level custom actions: '${existingName}' and '${newName}'. Only the first action will be shown.`,
     INVALID_METADATA_IDS: (targetType: string, invalidIds: string[], supportedIds: string) => `Invalid metadata IDs for ${targetType.toLowerCase()}-level custom actions: ${invalidIds.join(', ')}. Supported metadata IDs: ${supportedIds}`,
     INVALID_DATA_MODEL_IDS: (targetType: string, invalidIds: string[], supportedIds: string) => `Invalid data model IDs for ${targetType.toLowerCase()}-level custom actions: ${invalidIds.join(', ')}. Supported data model IDs: ${supportedIds}`,
     INVALID_FIELDS: (targetType: string, invalidFields: string[], supportedFields: string) => `Invalid fields for ${targetType.toLowerCase()}-level custom actions: ${invalidFields.join(', ')}. Supported fields: ${supportedFields}`,

src/utils/custom-actions.spec.ts

@@ -268,46 +268,6 @@ describe('getCustomActions function', () => {
         });
     });
 
-    describe('Primary Action Conflicts', () => {
-        test('should warn about multiple primary actions for same target', () => {
-            const firstAction = {
-                id: 'first-id',
-                name: 'First Action',
-                target: CustomActionTarget.LIVEBOARD,
-                position: CustomActionsPosition.PRIMARY,
-            };
-            const secondAction = {
-                id: 'second-id',
-                name: 'Second Action',
-                target: CustomActionTarget.LIVEBOARD,
-                position: CustomActionsPosition.PRIMARY,
-            };
-            const result = getCustomActions([firstAction, secondAction]);
-            expect(result.actions).toHaveLength(1);
-            expect(result.actions[0]).toEqual(firstAction);
-            expect(result.errors).toHaveLength(1);
-            expect(result.errors[0]).toContain("Multiple primary actions found for liveboard-level custom actions");
-        });
-
-        test('should allow multiple primary actions for different targets', () => {
-            const liveboardAction = {
-                id: 'lb-id',
-                name: 'Liveboard Action',
-                target: CustomActionTarget.LIVEBOARD,
-                position: CustomActionsPosition.PRIMARY,
-            };
-            const vizAction = {
-                id: 'viz-id',
-                name: 'Viz Action',
-                target: CustomActionTarget.VIZ,
-                position: CustomActionsPosition.PRIMARY,
-            };
-            const result = getCustomActions([liveboardAction, vizAction]);
-            expect(result.actions).toHaveLength(2);
-            expect(result.errors).toEqual([]);
-        });
-    });
-
     describe('Metadata IDs Validation', () => {
         test('should reject invalid metadata IDs for LIVEBOARD', () => {
             const action = {

src/utils/custom-actions.ts

@@ -77,17 +77,6 @@ const validateCustomAction = (action: CustomAction, primaryActionsPerTarget: Map
         errors.push(CUSTOM_ACTIONS_ERROR_MESSAGE.INVALID_POSITION(position, targetType, supportedPositions));
     }
 
-    // Check for primary action conflicts (this is a warning, not a validation
-    // failure)
-    if (position === CustomActionsPosition.PRIMARY) {
-        const existingPrimaryAction = primaryActionsPerTarget.get(targetType);
-        if (existingPrimaryAction) {
-            errors.push(CUSTOM_ACTIONS_ERROR_MESSAGE.MULTIPLE_PRIMARY_ACTIONS(targetType, existingPrimaryAction.name, action.name));
-        } else {
-            primaryActionsPerTarget.set(targetType, action);
-        }
-    }
-
     // Validate metadata IDs
     if (metadataIds) {
         const invalidMetadataIds = Object.keys(metadataIds).filter(