Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't work with group permissions #1344

Closed
ghost opened this issue Aug 3, 2017 · 0 comments
Closed

Search doesn't work with group permissions #1344

ghost opened this issue Aug 3, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Aug 3, 2017

I noticed this behaviour:

I've a single user associated to many groups and all faqs are associated to groups. If I make a search (obviously after login) I doesn't get any faq.

I see in phpmyfaq/inc/PMF/Search/Resultset.php in function reviewResultset(Array $resultSet) that all results are reviewed basing on permissions. The first review is based on group permission and after there is this if statement:

// check permission for user
if ($permission || 'basic' === $this->_config->get('security.permLevel')) { ... }

The question is: if $permission is true (for user's group) why the faq will be reviewed on user's permission?

@thorsten thorsten self-assigned this Aug 4, 2017
@thorsten thorsten added the Bug label Aug 4, 2017
@thorsten thorsten added this to the 2.9.9 milestone Aug 4, 2017
@thorsten thorsten closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant