feat(config): improve Git fallback configuration and display

Author: thomas-vilte

internal/commands/config/set.go

@@ -98,9 +98,9 @@ func (c *ConfigCommandFactory) newSetCommand(t *i18n.Translations, cfg *config.C
 				}
 			case "active-vcs", "active_vcs":
 				targetCfg.ActiveVCSProvider = value
-			case "git-name":
+			case "git.name", "git-name":
 				targetCfg.GitFallback.UserName = value
-			case "git-email":
+			case "git.email", "git-email":
 				targetCfg.GitFallback.UserEmail = value
 			default:
 				return fmt.Errorf("unknown configuration key: %s", key)

internal/commands/config/show.go

@@ -61,6 +61,17 @@ func (c *ConfigCommandFactory) newShowCommand(t *i18n.Translations, cfg *config.
 				fmt.Println(t.GetMessage("config_models.no_ai_models_configured", 0, nil))
 			}
 
+			if cfg.GitFallback.UserName != "" || cfg.GitFallback.UserEmail != "" {
+				fmt.Println()
+				fmt.Println(t.GetMessage("config_git.fallback_header", 0, nil))
+				if cfg.GitFallback.UserName != "" {
+					fmt.Printf("%s\n", t.GetMessage("config_git.fallback_name", 0, struct{ Name string }{cfg.GitFallback.UserName}))
+				}
+				if cfg.GitFallback.UserEmail != "" {
+					fmt.Printf("%s\n", t.GetMessage("config_git.fallback_email", 0, struct{ Email string }{cfg.GitFallback.UserEmail}))
+				}
+			}
+
 			localPath := config.GetRepoConfigPath()
 			if localPath != "" {
 				localCfg, err := config.LoadConfig(localPath)
@@ -71,6 +82,17 @@ func (c *ConfigCommandFactory) newShowCommand(t *i18n.Translations, cfg *config.
 					fmt.Printf("%s\n", t.GetMessage("language_label", 0, struct{ Lang string }{localCfg.Language}))
 					fmt.Printf("%s\n", t.GetMessage("emojis_label", 0, struct{ Emoji bool }{localCfg.UseEmoji}))
 					fmt.Printf("%s\n", t.GetMessage("config_models.active_ai_label", 0, struct{ IA config.AI }{localCfg.AIConfig.ActiveAI}))
+
+					if localCfg.GitFallback.UserName != "" || localCfg.GitFallback.UserEmail != "" {
+						fmt.Println()
+						fmt.Println(t.GetMessage("config_git.fallback_header", 0, nil))
+						if localCfg.GitFallback.UserName != "" {
+							fmt.Printf("%s\n", t.GetMessage("config_git.fallback_name", 0, struct{ Name string }{localCfg.GitFallback.UserName}))
+						}
+						if localCfg.GitFallback.UserEmail != "" {
+							fmt.Printf("%s\n", t.GetMessage("config_git.fallback_email", 0, struct{ Email string }{localCfg.GitFallback.UserEmail}))
+						}
+					}
 				}
 			}
 

internal/git/git_service.go

@@ -447,13 +447,17 @@ func (s *GitService) ValidateGitConfig(ctx context.Context) error {
 		return errors.ErrNotInGitRepo
 	}
 
-	validate := func(key string, errType *errors.AppError) error {
+	validate := func(key string, errType *errors.AppError, fallback string) error {
 		cmd := exec.CommandContext(ctx, "git", "config", key)
 		cmd.Dir = repoRoot
 		output, err := cmd.Output()
 		val := strings.TrimSpace(string(output))
 
 		if err != nil || val == "" {
+			if fallback != "" {
+				log.Info("git config not set, using fallback", "key", key, "fallback", fallback)
+				return nil
+			}
 			log.Error("git config check failed",
 				"key", key,
 				"error", err,
@@ -465,19 +469,11 @@ func (s *GitService) ValidateGitConfig(ctx context.Context) error {
 		return nil
 	}
 
-	if err := validate("user.name", errors.ErrGitUserNotConfigured); err != nil {
-		if s.fallbackName != "" {
-			log.Info("using fallback git user.name", "name", s.fallbackName)
-		} else {
-			return err
-		}
+	if err := validate("user.name", errors.ErrGitUserNotConfigured, s.fallbackName); err != nil {
+		return err
 	}
-	if err := validate("user.email", errors.ErrGitEmailNotConfigured); err != nil {
-		if s.fallbackEmail != "" {
-			log.Info("using fallback git user.email", "email", s.fallbackEmail)
-		} else {
-			return err
-		}
+	if err := validate("user.email", errors.ErrGitEmailNotConfigured, s.fallbackEmail); err != nil {
+		return err
 	}
 
 	return nil

internal/i18n/locales/active.en.toml

@@ -847,4 +847,9 @@ created_summary = "✅ Created {{.Count}} issue successfully"
 error_reading_file = "Error reading plan file: {{.Error}}"
 error_empty_file = "Plan file is empty"
 error_parsing_plan = "Error parsing plan: {{.Error}}"
+
+[config_git]
+fallback_header = "Git Fallback Configuration:"
+fallback_name = "  Git Name: {{.Name}}"
+fallback_email = "  Git Email: {{.Email}}"
 error_creating_issue = "Error creating issue: {{.Error}}"

internal/i18n/locales/active.es.toml

@@ -869,4 +869,9 @@ created_summary = "✅ {{.Count}} issue creado exitosamente"
 error_reading_file = "Error leyendo archivo de plan: {{.Error}}"
 error_empty_file = "El archivo de plan está vacío"
 error_parsing_plan = "Error parseando plan: {{.Error}}"
-error_creating_issue = "Error creando issue: {{.Error}}"
+error_creating_issue = "Error creando issue: {{.Error}}"
+
+[config_git]
+fallback_header = "Configuración Git Fallback:"
+fallback_name = "  Nombre Git: {{.Name}}"
+fallback_email = "  Email Git: {{.Email}}"