Skip to content

Commit 5544270

Browse files
committed
refactor(i18n): Agrupa claves de traducción de servicios AI (#47)
1 parent 17b538d commit 5544270

6 files changed

Lines changed: 9 additions & 9 deletions

File tree

internal/infrastructure/ai/gemini/commit_summarizer_service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func NewGeminiService(ctx context.Context, cfg *config.Config, trans *i18n.Trans
5454
Backend: genai.BackendGeminiAPI,
5555
})
5656
if err != nil {
57-
msg := trans.GetMessage("error_gemini_client", 0, map[string]interface{}{
57+
msg := trans.GetMessage("ai_service.error_ai_client", 0, map[string]interface{}{
5858
"Error": err,
5959
})
6060
return nil, fmt.Errorf("%s", msg)

internal/infrastructure/ai/gemini/pull_requests_summarizer_service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func NewGeminiPRSummarizer(ctx context.Context, cfg *config.Config, trans *i18n.
4040
Backend: genai.BackendGeminiAPI,
4141
})
4242
if err != nil {
43-
msg := trans.GetMessage("error_gemini_client", 0, map[string]interface{}{
43+
msg := trans.GetMessage("ai_service.error_ai_client", 0, map[string]interface{}{
4444
"Error": err,
4545
})
4646
return nil, fmt.Errorf("%s", msg)

internal/infrastructure/ai/gemini/release_generator.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func NewReleaseNotesGenerator(ctx context.Context, cfg *config.Config, trans *i1
4747
Backend: genai.BackendGeminiAPI,
4848
})
4949
if err != nil {
50-
msg := trans.GetMessage("error_gemini_client", 0, map[string]interface{}{
50+
msg := trans.GetMessage("ai_service.error_ai_client", 0, map[string]interface{}{
5151
"Error": err,
5252
})
5353
return nil, fmt.Errorf("%s", msg)
@@ -75,14 +75,14 @@ func (g *ReleaseNotesGenerator) GenerateNotes(ctx context.Context, release *mode
7575

7676
resp, err := g.client.Models.GenerateContent(ctx, g.model, genai.Text(prompt), genConfig)
7777
if err != nil {
78-
msg := g.trans.GetMessage("error_generating_release_notes", 0, map[string]interface{}{
78+
msg := g.trans.GetMessage("ai_service.error_generating_release_notes", 0, map[string]interface{}{
7979
"Error": err,
8080
})
8181
return nil, fmt.Errorf("%s", msg)
8282
}
8383

8484
if len(resp.Candidates) == 0 {
85-
msg := g.trans.GetMessage("error_no_ai_response", 0, nil)
85+
msg := g.trans.GetMessage("ai_service.error_no_ai_response", 0, nil)
8686
return nil, fmt.Errorf("%s", msg)
8787
}
8888

internal/services/pull_request_service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func NewPRService(vcsClient ports.VCSClient, aiService ports.PRSummarizer, trans
3333

3434
func (s *PRService) SummarizePR(ctx context.Context, prNumber int, progress func(string)) (models.PRSummary, error) {
3535
if s.aiService == nil {
36-
msg := s.trans.GetMessage("ai_missing_for_pr", 0, nil)
36+
msg := s.trans.GetMessage("ai_missing.ai_missing_for_pr", 0, nil)
3737
return models.PRSummary{}, fmt.Errorf("%s", msg)
3838
}
3939

internal/services/pull_request_service_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,17 +162,17 @@ func TestPRService_SummarizePR_UpdateError(t *testing.T) {
162162
}
163163

164164
func TestPRService_SummarizePR_NilAIService(t *testing.T) {
165-
ctx := context.Background()
166165
trans, err := i18n.NewTranslations("es", "../i18n/locales")
167166
require.NoError(t, err)
168167
cfg := &config.Config{}
169168

170169
service := NewPRService(nil, nil, trans, cfg)
171170

172-
_, err = service.SummarizePR(ctx, 123, func(s string) {})
171+
summary, err := service.SummarizePR(context.Background(), 1, func(msg string) {})
173172

174173
assert.Error(t, err)
175-
assert.Contains(t, err.Error(), "ai_missing_for_pr")
174+
assert.Contains(t, err.Error(), "La IA no está configurada")
175+
assert.Empty(t, summary.Title)
176176
}
177177

178178
func TestPRService_SummarizePR_WithRelatedIssues(t *testing.T) {

matecommit

27.8 MB
Binary file not shown.

0 commit comments

Comments
 (0)