Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple currency support in MarketplaceV3 DirectListings contract. #590

Closed
goldnite opened this issue Dec 14, 2023 · 1 comment
Closed

Multiple currency support in MarketplaceV3 DirectListings contract. #590

goldnite opened this issue Dec 14, 2023 · 1 comment

Comments

@goldnite
Copy link
Contributor

MarketplaceV3 contracts only support a single currency for DirectListing.
It would be nice to support multiple currencies when making payments.
For example, an NFT could be sold for 1 ETH or 2000 USDT.
It can facilitate NFT transactions among marketplace users.
@nkrishang
Copy link
Contributor

Hi @goldnite 👋🏽 the MarketplaceV3 contract does have this feature. See DirectListings.approveCurrencyForBuyer here: https://github.com/thirdweb-dev/contracts/blob/main/contracts/prebuilts/marketplace/direct-listings/DirectListingsLogic.sol#L215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkrishang @goldnite