Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test & gas benchmark for Marketplace contract to gasreport.txt #472

Closed
kien-ngo opened this issue Aug 17, 2023 · 3 comments
Closed

Add test & gas benchmark for Marketplace contract to gasreport.txt #472

kien-ngo opened this issue Aug 17, 2023 · 3 comments

Comments

@kien-ngo
Copy link

No description provided.

@kien-ngo kien-ngo changed the title Add test & gas benchmark for Marketplace contract Add test & gas benchmark for Marketplace contract to gasreport.txt Aug 17, 2023
@SonuBardai
Copy link

Hey @kien-ngo! I would love to help with this issue. I've setup the project locally and I'm going through the marketplace contract and all the related code. I see that there's already some tests written for the marketplace contract. Can you help me with what would be a good place to start, and what functions we're looking to add tests for? I'm also on the discord channel if that's a better place to talk about this. Thanks

@kien-ngo
Copy link
Author

Hey @SonuBardai, thanks for reaching out. Let me tag @nkrishang here since I'm not the one in charge so I'm not sure what the team have in mind in terms of current road map.

Feel free to reach out on Discord anyway ^

@nkrishang
Copy link
Contributor

Hey 👋🏽 I'll figure out an easier way to view all our contract benchmarks.

In the meantime, you can run any of the MarketplaceV3 tests using the forge test command with -vvvv tag to get the full gas consumption profile of any contract calls involved. Example:

forge test --mc MarketplaceEnglishAuctionsTest --mt test_state_createAuction -vvvv`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants