Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still maintained? #22

Open
M-Reimer opened this issue Oct 31, 2021 · 1 comment
Open

Is this still maintained? #22

M-Reimer opened this issue Oct 31, 2021 · 1 comment

Comments

@M-Reimer
Copy link

I'm using your library in a light controller that I built based on an Arduino Nano. This runs 24/7 and is responsible to switch on some outdoor lighting based on some time rules and external sensors. Actually this works really well usually.

But today it, again, failed to "survive" the switch from CEST to CET. I took some time to finally find out what is going wrong here. I literally spent hours debugging my own code until I decided to have a look at the DCF library. And the reason, finally, was pretty obvious.

You use "now()" to get a timestamp. If the DST switch happens, then "now()" jumps one hour and now some of your DCF time validation routines are broken until I powercycle the whole controller.

I could fix that, but I'm asking myself if the library actually is still maintained? If you consider the library as being "unmaintained", I would continue maintaining it under the same name. I would continue with a different name otherwise.

@t-luetkenhaus
Copy link

@M-Reimer how did you fix it?
Could you please publish your changes? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants