Fix #242

theseer · Jan 9, 2018 · 950b451 · 950b451
1 parent d4bdbcd
commit 950b451
Show file tree

Hide file tree

Showing 4 changed files with 60 additions and 1 deletion.
diff --git a/src/Application.php b/src/Application.php
@@ -153,6 +153,13 @@ public function runCollector(CollectorConfig $config) {
                         $this->logger->log(' - ' . $class . ' (missing ' . $missing . ')');
                     }
                 }
+
+                if ($resolver->hasErrors()) {
+                    $this->logger->log('The following unit(s) caused errors during inheritance resolution:');
+                    foreach($resolver->getErrors() as $class => $error) {
+                        $this->logger->log(' - ' . $class . ': ' . implode(', ', $error));
+                    }
+                }
             }
             $this->logger->log("Collector process completed\n");
         }

diff --git a/src/collector/InheritanceResolver.php b/src/collector/InheritanceResolver.php
@@ -37,8 +37,8 @@
 namespace TheSeer\phpDox\Collector {
 
     use TheSeer\fDOM\fDOMDocument;
-    use TheSeer\phpDox\ProgressLogger;
     use TheSeer\phpDox\InheritanceConfig;
+    use TheSeer\phpDox\ProgressLogger;
 
     /**
      * Inheritance resolving class
@@ -67,6 +67,11 @@ class InheritanceResolver {
          */
         private $unresolved = array();
 
+        /**
+         * @var array
+         */
+        private $errors = array();
+
         /**
          * @param ProgressLogger $logger
          */
@@ -153,6 +158,22 @@ public function getUnresolved() {
             return $this->unresolved;
         }
 
+        public function hasErrors() {
+            return count($this->errors) > 0;
+        }
+
+        public function getErrors() {
+            return $this->errors;
+        }
+
+        private function addError(AbstractUnitObject $unit, $errorInfo) {
+            $unitName = $unit->getName();
+            if (!isset($this->errors[$unitName])) {
+                $this->errors[$unitName] = array();
+            }
+            $this->errors[$unitName][] = $errorInfo;
+        }
+
         private function addUnresolved(AbstractUnitObject $unit, $missingUnit) {
             $unitName = $unit->getName();
             if (!isset($this->unresolved[$unitName])) {
@@ -212,6 +233,17 @@ private function processImplements(AbstractUnitObject $unit, AbstractUnitObject
             $this->project->registerForSaving($unit);
             $this->project->registerForSaving($implements);
 
+            if (!$implements instanceof InterfaceObject) {
+                $this->addError(
+                    $unit,
+                    sprintf(
+                        'Trying to implement "%s" which is a %s',
+                        $implements->getName(),
+                        $implements->getType()
+                    )
+                );
+                return;
+            }
             $implements->addImplementor($unit);
             $unit->importExports($implements, 'interface');
 

diff --git a/tests/data/issue242/src/test.php b/tests/data/issue242/src/test.php
@@ -0,0 +1,5 @@
+<?php
+
+class test { }
+
+class foo implements test {}
diff --git a/tests/data/issue242/test.xml b/tests/data/issue242/test.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<phpdox xmlns="http://xml.phpdox.net/config" silent="false">
+
+    <project name="phpDox-issue" source="${basedir}/src" workdir="${basedir}/xml">
+
+        <collector publiconly="false" backend="parser" />
+
+        <generator output="${basedir}/docs">
+            <build engine="html" enabled="true" output="html" />
+            <build engine="xml" enabled="true" output="xml" />
+        </generator>
+
+    </project>
+
+</phpdox>