Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow longer scripts #11

Open
frankracis opened this issue Jul 10, 2021 · 1 comment
Open

Allow longer scripts #11

frankracis opened this issue Jul 10, 2021 · 1 comment

Comments

@frankracis
Copy link

The 128 byte packet size isn't enough to handle some event scripts for the WT CJ4, possibly others. For instance, pressing the BARO knob runs the script:

(L:XMLVAR_Baro1_ForcedToSTD) ! (>L:XMLVAR_Baro1_ForcedToSTD) 
(L:XMLVAR_Baro1_ForcedToSTD) if{ 
      (A:KOHLSMAN SETTING MB:1, mbars) 16 * (>L:XMLVAR_Baro1_SavedPressure) 
      1 (>K:BAROMETRIC_STD_PRESSURE) 
} els{ 
      1 (L:XMLVAR_Baro1_SavedPressure) (>K:2:KOHLSMAN_SET)
}

The quickest solution would be to just increase kPacketDataSize to 256 or 512. (This example was actually 257 characters)

@theomessin
Copy link
Owner

Hi @frankracis, yes, the plan was to increase the PacketDataSize eventually. There's probably something to be said about minifying RNP code before sending it through. There's more research to be done on what the most efficient solution is (see #10). Feel free to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants