Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: data-toggle-theme example is not complete #42

Open
zefranck opened this issue Jan 14, 2025 · 2 comments
Open

docs: data-toggle-theme example is not complete #42

zefranck opened this issue Jan 14, 2025 · 2 comments

Comments

@zefranck
Copy link

On which page do you see this issue?

https://flyonui.com/docs/components/theme-controller/

Describe the issue

Step 3: Basic use case of theme-change.

The below example showcase the toggle functionality using the switch component.
<input type="checkbox" data-toggle-theme="luxury" class="switch" />

the working example is

The below example showcase the toggle functionality using the switch component.
<input type="checkbox" value="dark" class="switch theme-controller" data-toggle-theme="dark,light"/>

What browsers are you seeing the problem on?

No response

Copy link

Hi @zefranck

Thank you for your support in helping us improve FlyonUI!

We’ve received your submission and will respond within few business days. Our team handles issues one at a time, and we’ll be reviewing yours as soon as possible.

In the meantime, any additional details or a reproducible example would be greatly appreciated and will help us resolve the issue more efficiently.

Thank you for your patience and understanding!

@OmkarOza
Copy link
Member

Hello @zefranck,

Thank you for sharing your valuable insights.

Your example is indeed accurate and works perfectly in scenarios where users do not have a default theme set or do not wish to configure one. However, in most cases, users tend to set a default theme for their application and toggle between the default and their desired themes.

That said, we greatly appreciate your input and will definitely consider including your example in future updates.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants