pass parameters by const reference

Author: thekvs

src/config.cpp

@@ -64,7 +64,7 @@ Config::has_notifications() const
 }
 
 void
-Config::set_last_played_station(Glib::ustring station)
+Config::set_last_played_station(const Glib::ustring& station)
 {
     last_station = station;
     save_config();

src/config.hpp

@@ -22,7 +22,7 @@ class Config
     void set_config_file(const std::string& name);
     void load_config();
     bool has_last_station();
-    void set_last_played_station(Glib::ustring station);
+    void set_last_played_station(const Glib::ustring& station);
     Glib::ustring get_last_played_station() const;
     bool has_notifications() const;
 

src/player.cpp

@@ -22,7 +22,7 @@ Player::init(int argc, char** argv)
 }
 
 void
-Player::play(Glib::ustring url, Glib::ustring station)
+Player::play(const Glib::ustring& url, const Glib::ustring& station)
 {
     init_streams(url, station);
     play();
@@ -68,7 +68,7 @@ Player::get_playbin()
 }
 
 void
-Player::set_stream(Glib::ustring url)
+Player::set_stream(const Glib::ustring& url)
 {
     playbin->property_uri() = url;
 }
@@ -208,7 +208,7 @@ Player::has_station()
 }
 
 void
-Player::init_streams(Glib::ustring data_url, Glib::ustring station)
+Player::init_streams(const Glib::ustring& data_url, const Glib::ustring& station)
 {
     bool ok;
 
@@ -222,7 +222,7 @@ Player::init_streams(Glib::ustring data_url, Glib::ustring station)
 }
 
 void
-Player::set_config(std::shared_ptr<Config> cfg)
+Player::set_config(const std::shared_ptr<Config>& cfg)
 {
     config = cfg;
     playlist.set_config(cfg);

src/player.hpp

@@ -31,7 +31,7 @@ class Player
     Player(const Player&) = delete;
 
     bool init(int argc, char** argv);
-    void play(Glib::ustring url, Glib::ustring station = Glib::ustring());
+    void play(const Glib::ustring& url, const Glib::ustring& station = Glib::ustring());
     void play();
     void pause();
     void stop();
@@ -41,8 +41,8 @@ class Player
     bool has_station();
     Glib::RefPtr<PlayBin> get_playbin();
 
-    void init_streams(Glib::ustring data_url, Glib::ustring station);
-    void set_config(std::shared_ptr<Config> cfg);
+    void init_streams(const Glib::ustring& data_url, const Glib::ustring& station);
+    void set_config(const std::shared_ptr<Config>& cfg);
 
     std::shared_ptr<EventManager> em;
 
@@ -57,7 +57,7 @@ class Player
     Glib::ustring current_station;
 
     bool on_bus_message(const Glib::RefPtr<Gst::Bus>& bus, const Glib::RefPtr<Gst::Message>& message);
-    void set_stream(Glib::ustring url);
+    void set_stream(const Glib::ustring& url);
     void set_buffer_size(int size);
     void play_next_stream();
 };

src/playlist.cpp

@@ -46,7 +46,7 @@ Playlist::init()
 }
 
 std::tuple<bool, MediaStreams>
-Playlist::get_streams(std::string url)
+Playlist::get_streams(const std::string& url)
 {
     MediaStreams streams;
 
@@ -84,13 +84,13 @@ Playlist::get_streams(std::string url)
 }
 
 void
-Playlist::set_config(std::shared_ptr<Config> cfg)
+Playlist::set_config(const std::shared_ptr<Config>& cfg)
 {
     config = cfg;
 }
 
 void
-Playlist::prepare_playlist_request(std::string url, bool only_headers)
+Playlist::prepare_playlist_request(const std::string& url, bool only_headers)
 {
     data.clear();
     curl_easy_reset(handle);
@@ -146,7 +146,7 @@ Playlist::get_content_type()
 }
 
 MediaStreams
-Playlist::run_playlist_decoders(std::string url)
+Playlist::run_playlist_decoders(const std::string& url)
 {
     MediaStreams streams;
     bool extracted = false;

src/playlist.hpp

@@ -30,8 +30,8 @@ class Playlist
     ~Playlist();
 
     bool init();
-    std::tuple<bool, MediaStreams> get_streams(std::string url);
-    void set_config(std::shared_ptr<Config> cfg);
+    std::tuple<bool, MediaStreams> get_streams(const std::string& url);
+    void set_config(const std::shared_ptr<Config>& cfg);
 
 private:
     CURL* handle = nullptr;
@@ -46,10 +46,10 @@ class Playlist
 
     std::map<PlaylistDecoderType, std::shared_ptr<PlaylistDecoder>> decoders;
 
-    void prepare_playlist_request(std::string url, bool only_headers);
+    void prepare_playlist_request(const std::string& url, bool only_headers);
     long get_http_status();
     std::string get_content_type();
-    MediaStreams run_playlist_decoders(std::string url);
+    MediaStreams run_playlist_decoders(const std::string& url);
     bool has_prefix(const std::string& prefix, const std::string& str);
     PlaylistDecoderType guess_playlist_decoder_type();
 

src/tray.cpp

@@ -155,7 +155,7 @@ RadioTrayLite::on_about_button()
 }
 
 void
-RadioTrayLite::on_station_button(Glib::ustring group_name, Glib::ustring station_name, Glib::ustring station_url)
+RadioTrayLite::on_station_button(const Glib::ustring& group_name, const Glib::ustring& station_name, const Glib::ustring& station_url)
 {
     player->play(station_url, station_name);
 
@@ -368,7 +368,7 @@ RadioTrayLite::set_current_station(bool turn_on)
 }
 
 void
-RadioTrayLite::set_current_broadcast(Glib::ustring info)
+RadioTrayLite::set_current_broadcast(const Glib::ustring& info)
 {
     auto split = [](const Glib::ustring& info, size_t size) {
         if (info.size() <= size) {
@@ -402,7 +402,7 @@ RadioTrayLite::set_current_broadcast(Glib::ustring info)
 }
 
 void
-RadioTrayLite::on_station_changed_signal(Glib::ustring station, StationState state)
+RadioTrayLite::on_station_changed_signal(const Glib::ustring& station, StationState state)
 {
     if (state == em->state) {
         return;
@@ -426,15 +426,15 @@ RadioTrayLite::on_station_changed_signal(Glib::ustring station, StationState sta
 }
 
 void
-RadioTrayLite::on_broadcast_info_changed_signal(Glib::ustring /*station*/, Glib::ustring info)
+RadioTrayLite::on_broadcast_info_changed_signal(const Glib::ustring& /*station*/, const Glib::ustring& info)
 {
     set_current_broadcast(info);
 
     LOG(DEBUG) << info;
 }
 
 void
-RadioTrayLite::copy_default_bookmarks(std::string src_file)
+RadioTrayLite::copy_default_bookmarks(const std::string& src_file)
 {
     auto home = getenv("HOME");
     if (home == nullptr) {

src/tray.hpp

@@ -76,7 +76,7 @@ class RadioTrayLite
 
     void on_quit_button();
     void on_about_button();
-    void on_station_button(Glib::ustring group_name, Glib::ustring station_name, Glib::ustring station_url);
+    void on_station_button(const Glib::ustring& group_name, const Glib::ustring& station_name, const Glib::ustring& station_url);
     void on_reload_button();
     void on_current_station_button();
 
@@ -88,12 +88,12 @@ class RadioTrayLite
     bool parse_bookmarks_file();
     void load_configuration();
     void set_current_station(bool turn_on);
-    void set_current_broadcast(Glib::ustring info = Glib::ustring("Idle"));
+    void set_current_broadcast(const Glib::ustring& info = Glib::ustring("Idle"));
 
-    void on_station_changed_signal(Glib::ustring station, StationState state);
-    void on_broadcast_info_changed_signal(Glib::ustring station, Glib::ustring info);
+    void on_station_changed_signal(const Glib::ustring& station, StationState state);
+    void on_broadcast_info_changed_signal(const Glib::ustring& station, const Glib::ustring& info);
 
-    void copy_default_bookmarks(std::string src_file);
+    void copy_default_bookmarks(const std::string& src_file);
 
     bool file_exists(const std::string& dir, const std::string& file);
     bool dir_exists(const std::string& dir);