Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku stack update and package.json updates #973

Open
grumpyinca opened this issue Jan 2, 2025 · 3 comments
Open

Heroku stack update and package.json updates #973

grumpyinca opened this issue Jan 2, 2025 · 3 comments
Assignees
Milestone

Comments

@grumpyinca
Copy link
Contributor

Following publication of ODOP version 5.1, the client package.json file is in need of update and cleanup. This includes:

  1. move patch-package and react-app-rewired from "devDependencies" to "dependencies"
  2. Align the Heroku environment variables between staging and production

Any other items ?

The possibility of releasing these changes as a version 5.1.1 was briefly considered.

@grumpyinca grumpyinca added this to the ODOP 5.2 milestone Jan 2, 2025
@1fifoto
Copy link
Collaborator

1fifoto commented Jan 4, 2025

We have agreed that staging's and production's NODE_ENV is to be set always to 'production' in its Setting's config variables

@1fifoto
Copy link
Collaborator

1fifoto commented Jan 4, 2025

The current staging's and production's config variable NPM_CONFIG_PRODUCTION is set to 'false'.

@1fifoto
Copy link
Collaborator

1fifoto commented Jan 4, 2025

We need to include updating the Heroku stack from Heroku-22 to Heroku-24.

We need still to test moving patch-package and react-app-rewired from "devDependencies" to "dependencies". If successful, then we need to remove NPM_CONFIG_PRODUCTION='false' (or set it to 'true').

@1fifoto 1fifoto changed the title package.json updates Heroku stack update and package.json updates Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants