Skip to content

Commit 97a07f3

Browse files
committed
changed findAndUpdate to updateOne.
1 parent cf3158c commit 97a07f3

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

src/managers/dao.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -192,11 +192,11 @@ function updateFieldWithMethod(userId, method, fieldName, fieldValue, cbk){
192192
}
193193
};
194194

195-
usersCollection.findOneAndUpdate({ _id: userId }, data, { returnOriginal: false, projection: { password: 0 }}, function (err, updatedProfiles) {
195+
usersCollection.updateOne({ _id: userId }, data, function (err, res) {
196196
if (err) {
197197
return cbk(err, null);
198198
}
199-
return cbk(null, updatedProfiles);
199+
return cbk(null, res.modifiedCount);
200200
});
201201
}
202202

@@ -213,11 +213,11 @@ function addToArrayFieldById(userId, fieldName, fieldValue, cbk) {
213213
}
214214
}
215215
};
216-
usersCollection.findOneAndUpdate({ _id: userId }, data, { returnOriginal: false, projection: { password: 0 }}, function (err) {
216+
usersCollection.updateOne({ _id: userId }, data, function (err, res) {
217217
if (err) {
218218
return cbk(err, null);
219219
}
220-
return cbk(null, 1);
220+
return cbk(null, res.modifiedCount);
221221
});
222222
}
223223

tests-unit/dao.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,15 @@ describe('user dao', function () {
213213
const expectedField = 'field1';
214214
const expectedValue = 'value1';
215215

216-
fakeCollection.findOneAndUpdate = function (query, update, options, cbk) {
216+
fakeCollection.updateOne = function (query, update, cbk) {
217217
assert.equal(query._id, expectedUser.id);
218218
assert.equal(update.$set[expectedField], expectedValue);
219-
cbk(null, expectedUser);
219+
cbk(null, { modifiedCount: 1});
220220
};
221221

222222
dao.updateFieldWithMethod(expectedUser.id, '$set', expectedField, expectedValue, function (err, updates) {
223223
assert.equal(err, null);
224-
assert.deepEqual(updates, expectedUser);
224+
assert.deepEqual(updates, 1);
225225
return done();
226226
});
227227
});
@@ -231,15 +231,15 @@ describe('user dao', function () {
231231
const expectedField = 'field1';
232232
const expectedValue = ['value1', 'value2'];
233233

234-
fakeCollection.findOneAndUpdate = function (query, update, options, cbk) {
234+
fakeCollection.updateOne = function (query, update, cbk) {
235235
assert.equal(query._id, expectedUser.id);
236236
assert.equal(update.$pull[expectedField], expectedValue);
237-
cbk(null, expectedUser);
237+
cbk(null, { modifiedCount: 1});
238238
};
239239

240240
dao.updateFieldWithMethod(expectedUser.id, '$pull', expectedField, expectedValue, function (err, updates) {
241241
assert.equal(err, null);
242-
assert.equal(updates, expectedUser);
242+
assert.equal(updates, 1);
243243
return done();
244244
});
245245
});
@@ -249,15 +249,15 @@ describe('user dao', function () {
249249
const expectedField = 'field1';
250250
const expectedValue = 'value1';
251251

252-
fakeCollection.findOneAndUpdate = function (query, update, options, cbk) {
252+
fakeCollection.updateOne = function (query, update, cbk) {
253253
assert.equal(query._id, expectedUser.id);
254254
assert.equal(update.$set[expectedField], expectedValue);
255-
cbk(null, expectedUser);
255+
cbk(null, { modifiedCount: 1});
256256
};
257257

258258
dao.updateField(expectedUser.id, expectedField, expectedValue, function (err, updates) {
259259
assert.equal(err, null);
260-
assert.equal(updates, expectedUser);
260+
assert.equal(updates, 1);
261261
return done();
262262
});
263263
});
@@ -267,15 +267,15 @@ describe('user dao', function () {
267267
const expectedField = 'field1';
268268
const expectedValue = ['value1', 'value2'];
269269

270-
fakeCollection.findOneAndUpdate = function (query, update, options, cbk) {
270+
fakeCollection.updateOne = function (query, update, cbk) {
271271
assert.equal(query._id, expectedUser.id);
272272
assert.deepEqual(update.$pull[expectedField], expectedValue);
273-
cbk(null, expectedUser);
273+
cbk(null, { modifiedCount: 1});
274274
};
275275

276276
dao.removeFromArrayFieldById(expectedUser.id, expectedField, expectedValue, function (err, added) {
277277
assert.equal(err, null);
278-
assert.equal(added, expectedUser);
278+
assert.equal(added, 1);
279279
return done();
280280
});
281281
});
@@ -285,10 +285,10 @@ describe('user dao', function () {
285285
const expectedField = 'field1';
286286
const expectedValue = ['value1', 'value2'];
287287

288-
fakeCollection.findOneAndUpdate = function (query, update, options, cbk) {
288+
fakeCollection.updateOne = function (query, update, cbk) {
289289
assert.equal(query._id, expectedUser.id);
290290
assert.deepEqual(update.$push[expectedField], {$each: [expectedValue]});
291-
cbk(null, expectedUser);
291+
cbk(null, {modifiedCount: 1});
292292
};
293293

294294
dao.addToArrayFieldById(expectedUser.id, expectedField, expectedValue, function (err, added) {

0 commit comments

Comments
 (0)