Skip to content

Run permissions tests from Foreman core #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ekohl wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Run permissions tests from Foreman core #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/tasks/foreman_plugin_template_tasks.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@ end
# Tests
namespace :test do
desc 'Test ForemanPluginTemplate'
Rake::TestTask.new(:foreman_plugin_template) do |t|
test_dir = File.expand_path('../../test', __dir__)
t.libs << 'test'
t.libs << test_dir
t.pattern = "#{test_dir}/**/*_test.rb"
Rake::TestTask.new(:foreman_plugin_template => 'db:test:prepare') do |t|
t.libs << ForemanPluginTemplate::Engine.root.join('test')
Copy link
Member

@evgeni evgeni Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this, libs was ['test', File.expand_path('../../test', __dir__)], now it's only [ForemanPluginTemplate::Engine.root.join('test')], doesn't that mean the bare test one is not added anymore, which means the test helpers from Foreman are not available anymor?

Copy link

@nadjaheitmann nadjaheitmann Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just tried that and this is exactly what happened: https://github.com/ATIX-AG/foreman_resource_quota/actions/runs/12009329940/job/33473856106#step:21:18

t.pattern = ForemanPluginTemplate::Engine.root.join('test', '**', '*_test.rb')
t.test_files = [Rails.root.join('test/unit/foreman/access_permissions_test.rb')]
Copy link
Member

@evgeni evgeni Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is the important line of this PR and we should get that merged.

Copy link

@nadjaheitmann nadjaheitmann Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think that this should get merged because we just stumbled across some permissions issue during plugin development and I realized only now that this permissions test got lost during the move to the unified github actions workflow.

t.verbose = true
t.warning = false
end
Expand Down