Skip to content

Fixes #37643 Hostname Inconsistency in WebUI #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pafernanr wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixes #37643 Hostname Inconsistency in WebUI #638

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34d1db2
Fixes #37643 Hostname Inconsistency in WebUI
pafernanr Jul 11, 2024
5f1e343
Fixes #37643 Hostname Inconsistency in WebUI
pafernanr Jul 22, 2024
6cc1d8d
Merge branch 'theforeman:develop' into develop
pafernanr Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/controllers/discovered_hosts_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,14 @@ def destroy

def edit
quick = params.delete(:quick_submit)
name = @host.name
@host = ::ForemanDiscovery::HostConverter.to_managed(@host, true, false, discovered_host_params_host) unless @host.nil?
setup_host_class_variables
@override_taxonomy = true
# need to permit this one but don't know how
if quick
perform_update(@host, _('Successfully provisioned %s') % @host.name)
name = @host.name if name.blank?
perform_update(@host, _('Successfully started provision for %s') % name)
else
@host.build = true
render :template => 'discovered_hosts/edit'
Expand Down