increases coverage; indicates ShellCompDirectiveNoFileComp

Signed-off-by: thediveo <[email protected]>

Author: thediveo

Diff for: README.md

@@ -3,7 +3,7 @@
 [![GitHub](https://img.shields.io/github/license/thediveo/enumflag)](https://img.shields.io/github/license/thediveo/enumflag)
 ![build and test](https://github.com/thediveo/enumflag/workflows/build%20and%20test/badge.svg?branch=master)
 [![Go Report Card](https://goreportcard.com/badge/github.com/thediveo/enumflag/v2)](https://goreportcard.com/report/github.com/thediveo/enumflag/v2)
-![Coverage](https://img.shields.io/badge/Coverage-97.3%25-brightgreen)
+![Coverage](https://img.shields.io/badge/Coverage-100.0%25-brightgreen)
 
 `enumflag/v2` is a Golang package which supplements the Golang CLI flag packages
 [spf13/cobra](https://github.com/spf13/cobra) and

Diff for: flag_test.go

@@ -17,6 +17,7 @@ package enumflag
 import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	"github.com/spf13/cobra"
 )
 
 var _ = Describe("flag", func() {
@@ -81,4 +82,16 @@ var _ = Describe("flag", func() {
 
 	})
 
+	It("returns completors", func() {
+		cmd := &cobra.Command{}
+		foomodes := []FooModeTest{fmBar, fmFoo}
+		val := NewSlice(&foomodes, "modes", FooModeIdentifiersTest, EnumCaseInsensitive)
+		cmd.PersistentFlags().Var(val, "mode", "blahblah")
+		Expect(val.RegisterCompletion(cmd, "mode", Help[FooModeTest]{
+			fmFoo: "gives a foo",
+			fmBar: "gives a bar",
+			fmBaz: "gives a baz",
+		})).To(Succeed())
+	})
+
 })

Diff for: test/enumflag-testing/main.go

@@ -15,6 +15,7 @@
 package main
 
 import (
+	"io"
 	"os"
 
 	"github.com/spf13/cobra"
@@ -39,11 +40,12 @@ var FooModeNames = map[FooMode][]string{
 	Baz: {"baz"},
 }
 
-func newRootCmd() *cobra.Command {
+func newRootCmd(w io.Writer) *cobra.Command {
 	rootCmd := &cobra.Command{
 		Use: Name,
 		Run: func(*cobra.Command, []string) {},
 	}
+	rootCmd.SetOutput(w)
 
 	testCmd := &cobra.Command{
 		Use:  "test the canary",
@@ -68,9 +70,10 @@ func main() {
 	// Cobra automatically adds a "__complete" command to our root command
 	// behind the scenes, unless we specify one explicitly. It also adds a
 	// "complete" sub command if we're adding at least one sub command.
-	if err := newRootCmd().Execute(); err != nil {
+	if err := newRootCmd(stdout).Execute(); err != nil {
 		osExit(1)
 	}
 }
 
 var osExit = os.Exit
+var stdout io.Writer = os.Stdout

Diff for: test/enumflag-testing/main_test.go

@@ -16,6 +16,7 @@ package main
 
 import (
 	"bytes"
+	"io"
 	"os"
 
 	"github.com/spf13/cobra"
@@ -30,9 +31,8 @@ var _ = Describe("enumflag-testing canary", func() {
 	var out *bytes.Buffer
 
 	BeforeEach(func() {
-		rootCmd = newRootCmd()
 		out = &bytes.Buffer{}
-		rootCmd.SetOutput(out)
+		rootCmd = newRootCmd(out)
 	})
 
 	It("has a hidden __complete command", func() {
@@ -55,12 +55,14 @@ var _ = Describe("enumflag-testing canary", func() {
 
 	It("reaches 100% :p", func() {
 		exitCode := -1
-		defer func(old func(int), oldargs []string) {
+		defer func(old func(int), oldargs []string, out io.Writer) {
 			osExit = old
 			os.Args = oldargs
-		}(osExit, os.Args)
+			stdout = out
+		}(osExit, os.Args, os.Stdout)
 		osExit = func(code int) { exitCode = code }
 		os.Args = []string{os.Args[0], "froobz"}
+		stdout = &bytes.Buffer{}
 		main()
 		Expect(exitCode).To(Equal(1))
 	})

Diff for: value_scalar.go

@@ -84,6 +84,6 @@ func (s *enumScalar[E]) NewCompletor(enums EnumIdentifiers[E], help Help[E]) Com
 		}
 	}
 	return func(*cobra.Command, []string, string) ([]string, cobra.ShellCompDirective) {
-		return completions, cobra.ShellCompDirectiveDefault
+		return completions, cobra.ShellCompDirectiveNoFileComp
 	}
 }

Diff for: value_slice.go

@@ -110,6 +110,6 @@ func (s *enumSlice[E]) NewCompletor(enums EnumIdentifiers[E], help Help[E]) Comp
 			}
 			filteredCompletions = append(filteredCompletions, prefix+completion)
 		}
-		return filteredCompletions, cobra.ShellCompDirectiveDefault
+		return filteredCompletions, cobra.ShellCompDirectiveNoFileComp | cobra.ShellCompDirectiveNoSpace
 	}
 }