Merge pull request #34 from moufmouf/throw_in_catch_ok

A throw Exception in a catch statement is ok

Author: moufmouf

src/Rules/Exceptions/DoNotThrowExceptionBaseClassRule.php

@@ -26,6 +26,11 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
+        if (!$node->expr instanceof Node\Expr\New_) {
+            // Only catch "throw new ..."
+            return [];
+        }
+
         $type = $scope->getType($node->expr);
 
         if ($type instanceof ObjectType) {

tests/Rules/Exceptions/data/throw_exception.php

@@ -15,3 +15,13 @@ function bar()
 {
     throw new \Exception('');
 }
+
+function baz()
+{
+    try {
+        //...
+    } catch (\Exception $e) {
+        // This is ok
+        throw $e;
+    }
+}