Skip to content

hotfix: use new package and set reload time #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

RobinSiep
Copy link
Member

@RobinSiep RobinSiep commented Sep 29, 2020

Code R Ticket

Please provide a link to the Code R Jira ticket if applicable

https://partypeak.atlassian.net/browse/AP-

Description

  • watchgod is now included in the standard package as specified here which is why the build currently breaks.
  • With the new Uvicorn release a configurable reload delay has also been introduced as specified here. I've set this to 1s which may help against the high CPU load we're seeing from the hot reload function.

Dependencies

Are there any dependencies in relation to pull requests in other Apollo repositories? If so please provide links to these pull requests

Additional notes

Nope

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #38 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1186      1193    +7     
=========================================
+ Hits          1186      1193    +7     
Impacted Files Coverage Δ
apollo/handlers/agent.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52b5bd...186f730. Read the comment docs.

@rikvanderwerf rikvanderwerf merged commit 87abe2e into develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants