Skip to content

Commit de9370e

Browse files
authoredAug 16, 2023
Rename makePNGScreenshot to screenshot to follow the webdriver naming. (#64)
1 parent 27ed8d8 commit de9370e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed
 

‎Sources/Session+Requests.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ extension Session {
2626

2727
/// screenshot()
2828
/// Take a screenshot of the current page.
29-
/// - Returns: The screenshot Data.
29+
/// - Returns: The screenshot data as a PNG file.
3030
/// https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidscreenshot
31-
public func makePNGScreenshot() throws -> Data {
31+
public func screenshot() throws -> Data {
3232
let screenshotRequest = ScreenshotRequest(self)
3333

3434
let base64: String = try webDriver.send(screenshotRequest).value

‎Tests/UnitTests/APIToRequestMappingTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class APIToRequestMappingTests: XCTestCase {
1717
XCTAssertEqual(try session.title, "mySession.title")
1818

1919
mockWebDriver.expect(path: "session/mySession/screenshot", method: .get) { WebDriverResponse(value: base64TestImage) }
20-
let data: Data = try session.makePNGScreenshot()
20+
let data: Data = try session.screenshot()
2121
XCTAssert(isPNG(data: data))
2222

2323
mockWebDriver.expect(path: "session/mySession/element", method: .post, type: Session.ElementRequest.self) {

‎Tests/WebDriverTests/SessionTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class SessionTests: XCTestCase {
4040
}
4141

4242
public func testScreenshot() throws {
43-
let data: Data = try Self.session.makePNGScreenshot()
43+
let data: Data = try Self.session.screenshot()
4444
XCTAssert(isPNG(data: data))
4545
}
4646

0 commit comments

Comments
 (0)
Please sign in to comment.