Use TimeoutType cases over static vars (#171)

Author: bootuz

Sources/WebDriver/Requests.swift

@@ -350,15 +350,15 @@ public enum Requests {
     // https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidtimeouts
     public struct SessionTimeouts: Request {
         public var session: String
-        public var type: String
+        public var type: TimeoutType
         public var ms: Double
 
         public var pathComponents: [String] { ["session", session, "timeouts"] }
         public var method: HTTPMethod { .post }
         public var body: Body { .init(type: type, ms: ms) }
 
         public struct Body: Codable {
-            public var type: String
+            public var type: TimeoutType
             public var ms: Double
         }
     }

Sources/WebDriver/Session.swift

@@ -34,7 +34,7 @@ public class Session {
             if newValue == _implicitWaitTimeout { return }
             if !emulateImplicitWait {
                 do {
-                    try setTimeout(type: TimeoutType.implicitWait, duration: newValue)
+                    try setTimeout(type: .implicitWait, duration: newValue)
                 } catch {
                     emulateImplicitWait = true
                 }
@@ -101,11 +101,11 @@ public class Session {
     }
 
     /// Sets a a timeout value on this session.
-    public func setTimeout(type: String, duration: TimeInterval) throws {
+    public func setTimeout(type: TimeoutType, duration: TimeInterval) throws {
         try webDriver.send(
             Requests.SessionTimeouts(session: id, type: type, ms: duration * 1000))
         // Keep track of the implicit wait to know when we need to override it.
-        if type == TimeoutType.implicitWait { _implicitWaitTimeout = duration }
+        if type == .implicitWait { _implicitWaitTimeout = duration }
     }
 
     public func execute(script: String, args: [String] = [], async: Bool = false) throws {

Sources/WebDriver/TimeoutType.swift

@@ -1,5 +1,5 @@
-public enum TimeoutType {
-    public static let script = "script"
-    public static let implicitWait = "implicit"
-    public static let pageLoad = "page load"
-}
+public enum TimeoutType: String, Codable {
+    case script
+    case implicitWait = "implicit"
+    case pageLoad = "page load"
+}

Tests/UnitTests/APIToRequestMappingTests.swift

@@ -330,4 +330,12 @@ class APIToRequestMappingTests: XCTestCase {
         }
         XCTAssert(try session.source == "currentSource")
     }
+
+    func testSessionTimeouts() throws {
+        let mockWebDriver: MockWebDriver = MockWebDriver()
+        let session = Session(webDriver: mockWebDriver, existingId: "mySession")
+        mockWebDriver.expect(path: "session/mySession/timeouts", method: .post)
+        try session.setTimeout(type: .implicitWait, duration: 5)
+        XCTAssert(session.implicitWaitTimeout == 5.0)
+    }
 }