Skip to content
This repository has been archived by the owner on Sep 20, 2018. It is now read-only.

Refactor get_root_domain #1

Open
thatlittlegit opened this issue Apr 2, 2018 · 0 comments
Open

Refactor get_root_domain #1

thatlittlegit opened this issue Apr 2, 2018 · 0 comments
Assignees
@thatlittlegit
Labels
help wanted Extra attention is needed refactor Refactor a function (i.e. improve variable names)

Comments

@thatlittlegit
Copy link
Collaborator

get_root_domain ought to be refactored. Such a simple function, which I'm sure that could be compressed, is around 38 lines! We need to implement more Rust instead of basically porting JavaScript. It might help speed, too.
@thatlittlegit thatlittlegit added the refactor Refactor a function (i.e. improve variable names) label Apr 2, 2018
@thatlittlegit thatlittlegit added this to the Initial Release (1.0) milestone Apr 2, 2018
@thatlittlegit thatlittlegit self-assigned this Apr 2, 2018
@thatlittlegit thatlittlegit added the help wanted Extra attention is needed label Apr 2, 2018
@thatlittlegit thatlittlegit removed this from the Initial Release (1.0) milestone Apr 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thatlittlegit thatlittlegit

Labels
help wanted Extra attention is needed refactor Refactor a function (i.e. improve variable names)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thatlittlegit