wrong stitch type

[ixchow]

When running the example model and default constraints...

$ ./interface obj:tests/models/misc-cactus.obj load-constraints:tests/constraints/misc-cactus.cons obj-scale:10.0 stitch-width:3.66 stitch-height:1.73 save-traced:misc-cactus.st peel-step:-1

... I get an error from the scheduler about 'e' stitches with outgoing links:

$ ./schedule st:misc-cactus.st js:misc-cactus.js
ERROR: Stitch does not have proper in/out for type.
  line: '0 e a 1039 -1 1092 -1 3.41028 0.753821 3.9112'
ERROR: failed to load stitches from 'misc-cactus.st'.

Likely the problem is that make_stitch in ak-trace_graph.cpp needs to be more careful about setting stitch types; I'm not sure just yet how this is happening, though. A possible resolution would be to set stitch types later based on in/out counts.

[vid8687]

Hm, that ran fine for me (using models and constraints from the test data repo) and the stitch file looked sane. It looks like that is how stitch types are assigned.... if you have an accidentally updated constraint file, could you share it?

[ixchow]

This seems to be on the current code and constraints (autoknit 04dadd1, autoknit-tests a5c78a224af5dcd3a03db59bcb8db71928684146); perhaps this is a compiler difference (g++ 8.3.0).

Regardless, it seems like more thought might be needed as to whether a tuck+turn can happen on an end stitch. There seems to be logic to avoid that but I'm not sure it's correct.