-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Description
The misc-cactus.obj test used in the README produces a knitout file that fails to convert to a dat file.
Full set of steps (see test-cactus.sh):
rm -f misc-cactus.st misc-cactus.st misc-cactus.js misc-cactus.k misc-cactus.dat
node Maekfile.js
dist/interface obj:../autoknit-tests/models/misc-cactus.obj constraints:../autoknit-tests/constraints/misc-cactus.cons obj-scale:10.0 stitch-width:3.66 stitch-height:1.73 save-traced:misc-cactus.st peel-test:-1
dist/schedule st:misc-cactus.st js:misc-cactus.js
node misc-cactus.js
node ../knitout-backend-swg/knitout-to-dat.js misc-cactus.k misc-cactus.dat
The final step (converting to dat file) fails:
ERROR: can't bring in ["3"] with hook; hook is holding ["2"].
The problem here is that the yarn inserting logic in node_modules/autoknit-helpers.js should be doing a tuck pattern and getting the inserting hook out of the way immediately (as our original autoknit did). Instead, it's just trusting that yarns are used for a few stitches and it can releasehook after those few stitches elapse.
Metadata
Metadata
Assignees
Labels
No labels