publish: record the https clone URL in the StepLib, not the SSH one

`bitrise share create --git <url>` writes its argument into the published
step.yml as `source.git`, and that is the URL every user's Bitrise CLI clones
the Step from, anonymously. publish.sh passed the same git@github.com: URL it
uses to push, so the first release would have shipped a Step nobody outside
the org could run -- and a published version is immutable, so the only remedy
would have been to publish another one.

Pushing still uses SSH; only the recorded URL changes. Every entry in the
StepLib is https, including this Step's own 0.0.1, which is what the dry run
was checked against.

Author: jochen-testingbot

scripts/publish.sh

@@ -65,6 +65,14 @@ esac
 
 STEP_REPO="$(repo_for_step "$STEP_ID")" || die "no publish repository registered for '${STEP_ID}'"
 
+# Pushing needs SSH; the StepLib entry must not. `bitrise share create --git`
+# writes its argument into the published step.yml as `source.git`, and that is
+# the URL every user's Bitrise CLI clones the Step from -- anonymously. Ship
+# git@github.com: there and nobody outside the org can run the Step, and the
+# version is immutable, so the only fix would be to publish another one. Every
+# entry in the StepLib is https, including this Step's own 0.0.1.
+STEP_REPO_HTTPS="$(printf '%s' "$STEP_REPO" | sed -e 's#^git@github\.com:#https://github.com/#')"
+
 # --- preflight ---------------------------------------------------------------
 
 echo "==> Preflight"
@@ -90,6 +98,7 @@ STEP_BRANCH="$(remote_default_branch "$STEP_REPO")"
 echo "  step:     ${STEP_ID}"
 echo "  version:  ${VERSION}"
 echo "  mirror:   ${STEP_REPO} (${STEP_BRANCH})"
+echo "  steplib source.git: ${STEP_REPO_HTTPS}"
 echo "  steplib:  ${STEPLIB_FORK}"
 
 # --- mirror ------------------------------------------------------------------
@@ -105,7 +114,7 @@ Dry run -- nothing was pushed. Re-run with --push to perform:
 Then share to the StepLib:
 
   bitrise share start  -c ${STEPLIB_FORK}
-  bitrise share create --stepid ${STEP_ID} --tag ${VERSION} --git ${STEP_REPO}
+  bitrise share create --stepid ${STEP_ID} --tag ${VERSION} --git ${STEP_REPO_HTTPS}
   bitrise share audit  -c ${STEPLIB_FORK}
   bitrise share finish
 
@@ -140,7 +149,7 @@ cat <<EOF
 Now share it to the StepLib:
 
   bitrise share start  -c ${STEPLIB_FORK}
-  bitrise share create --stepid ${STEP_ID} --tag ${VERSION} --git ${STEP_REPO}
+  bitrise share create --stepid ${STEP_ID} --tag ${VERSION} --git ${STEP_REPO_HTTPS}
   bitrise share audit  -c ${STEPLIB_FORK}
   bitrise share finish