fix: allow double quotes in selector (#16)

Author: benmonro

src/index.js

@@ -38,11 +38,12 @@ Object.keys(queries).forEach(queryName => {
 })
 
 export const within = async sel => {
+  const sanitizedSel = sel.replace(/"/g, "'")
   await ClientFunction(
     new Function(
       ` 
-    const elem = document.querySelector("${sel}");
-    window.TestCafeTestingLibrary["within_${sel}"] = DomTestingLibrary.within(elem);
+    const elem = document.querySelector("${sanitizedSel}");
+    window.TestCafeTestingLibrary["within_${sanitizedSel}"] = DomTestingLibrary.within(elem);
 
     `,
     ),
@@ -52,21 +53,10 @@ export const within = async sel => {
   Object.keys(queries).forEach(queryName => {
     container[queryName] = Selector(
       new Function(
-        `return window.TestCafeTestingLibrary["within_${sel}"].${queryName}(...arguments)`,
+        `return window.TestCafeTestingLibrary["within_${sanitizedSel}"].${queryName}(...arguments)`,
       ),
     )
   })
 
   return container
-  // const container = {}
-
-  // Object.keys(queries).forEach(queryName => {
-  //   container[queryName] = Selector(
-  //     new Function(
-  //       `return DomTestingLibrary.within(document.querySelector("${sel}")).${queryName}(...arguments)`,
-  //     ),
-  //   )
-  // })
-
-  // return container
 }

tests/testcafe/within.js

@@ -18,3 +18,12 @@ test("queryByPlaceholder doesn't find anything", async t => {
 
   await t.expect(queryByPlaceholderText('Placeholder Text').exists).notOk()
 })
+
+test('quotes in selector', async t => {
+  const {getByText} = await within('div[id="nested"]')
+
+  await t
+    .click(getByText('Button Text'))
+    .expect(Selector('button').withExactText('Button Clicked').exists)
+    .ok()
+})