Skip to content

Commit 63c27e2

Browse files
feat: deprecate detectChanges in favor of detectChangesOnRender (#340)
1 parent 65cccbe commit 63c27e2

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

projects/testing-library/src/lib/models.ts

+17
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,25 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
7878
* const component = await render(AppComponent, {
7979
* detectChanges: false
8080
* })
81+
*
82+
* @deprecated
83+
* Use `detectChangesOnRender` instead
8184
*/
8285
detectChanges?: boolean;
86+
/**
87+
* @description
88+
* Invokes `detectChanges` after the component is rendered
89+
*
90+
* @default
91+
* true
92+
*
93+
* @example
94+
* const component = await render(AppComponent, {
95+
* detectChangesOnRender: false
96+
* })
97+
*/
98+
detectChangesOnRender?: boolean;
99+
83100
/**
84101
* @description
85102
* A collection of components, directives and pipes needed to render the component, for example, nested components of the component.

projects/testing-library/src/lib/testing-library.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ export async function render<SutType, WrapperType = SutType>(
4646
): Promise<RenderResult<SutType>> {
4747
const { dom: domConfig, ...globalConfig } = getConfig();
4848
const {
49-
detectChanges: detectChangesOnRender = true,
49+
detectChanges: detectChangesDeprecated = true,
50+
detectChangesOnRender: detectChangesOnRenderInput,
5051
declarations = [],
5152
imports = [],
5253
providers = [],
@@ -63,6 +64,8 @@ export async function render<SutType, WrapperType = SutType>(
6364
defaultImports = [],
6465
} = { ...globalConfig, ...renderOptions };
6566

67+
const detectChangesOnRender =
68+
detectChangesOnRenderInput === undefined ? detectChangesDeprecated : detectChangesOnRenderInput;
6669
dtlConfigure({
6770
eventWrapper: (cb) => {
6871
const result = cb();

0 commit comments

Comments
 (0)