Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Frame always visible since 14.1.0 #685

Open
cixio opened this issue Dec 18, 2024 · 8 comments
Open

iOS - Frame always visible since 14.1.0 #685

cixio opened this issue Dec 18, 2024 · 8 comments

Comments

@cixio
Copy link

cixio commented Dec 18, 2024

Describe the bug
showFrame is neither default false nor is false accepted als value - frame is always shown on iOS

To Reproduce
Create new App:

import React from 'react';
import { Camera, CameraType } from 'react-native-camera-kit';

function App(): React.JSX.Element {
  return (
		<Camera />
  );
}

export default App;

and run it
(dont forget to set Camera usage Description in Info.plist)

Expected behavior
Frame should not be shown

Version information
v14.1.0 on iOS 18.2

@cixio cixio changed the title iOS - Frame always visible iOS - Frame always visible since 14.1.0 Dec 22, 2024
@jadshep
Copy link

jadshep commented Dec 22, 2024

I'm experiencing this issue too

@cixio
Copy link
Author

cixio commented Dec 22, 2024

I think it has something to do with changes for new arch coming from @WoLewicki as of now i am going with 14.0 - but you have to disable new arch.

I added ENV['RCT_NEW_ARCH_ENABLED'] = "0" to the first line of ios/Podfile

@tortexy
Copy link

tortexy commented Jan 5, 2025

installing 14.1.0 & adding ENV['RCT_NEW_ARCH_ENABLED'] = "0" to podfile before pod install worked.

@WoLewicki
Copy link
Contributor

Hmm it is interesting since I am not doing anything specific regarding this prop:

id showFrame = CKConvertFollyDynamicToId(newProps.showFrame);
. I'll check it though.

@WoLewicki
Copy link
Contributor

Ok I checked the bug and here is the PR: #690. Could you check if it fixes the problem?

@cixio
Copy link
Author

cixio commented Jan 7, 2025

Fixed, thanks. The zoom works again too.

The only thing that surprises me is that on old arch it seems to use my normal camera (1x zoom), in new arch it uses the wide-angle-camera instead of the normal one.

@WoLewicki
Copy link
Contributor

Is it different than what happens on old architecture?

@cixio
Copy link
Author

cixio commented Jan 7, 2025

As this bug is fixed i created a new one for the zoom problem.

#691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants