add travis and fix typings

Author: terryyylim

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 120

.travis.yml

@@ -0,0 +1,10 @@
+language: python
+python:
+  - "3.6"
+
+install: 
+  pip install -r requirements.txt
+
+script:
+  - flake8
+  - mypy --config-file mypy.ini recommendations/*.py

mypy.ini

@@ -0,0 +1,6 @@
+[mypy]
+ignore_missing_imports = True
+disallow_untyped_calls = True
+disallow_untyped_defs = True
+disallow_incomplete_defs = True
+check_untyped_defs = True

recommendations/create_dataset.py

@@ -3,7 +3,6 @@
 import click
 import logging
 import pandas as pd
-import numpy as np
 import psycopg2 as pg
 from prettytable import PrettyTable
 from lightfm.data import Dataset as LFMDataset
@@ -170,7 +169,7 @@ def build_lightfm_dataset(self) -> None:
         logging.info(
             f'The shape of self.interactions {self.interactions.shape} '
             f'and self.weights {self.weights.shape} represent the user-item matrix.')
-            
+
 
 @click.command()
 @click.option('--config', default='production', help='the deployment target')
@@ -187,4 +186,4 @@ def main(config: str) -> None:
 if __name__ == "__main__":
     logger = helpers.get_logger()
 
-    main()
+    main()

recommendations/drop_data.py

@@ -5,6 +5,7 @@
 import helpers
 import schema
 
+
 @click.command()
 @click.option('--file', default='production', help='the dataset to drop from Postgres database')
 def main(file: str) -> None:
@@ -27,4 +28,4 @@ def main(file: str) -> None:
 if __name__ == "__main__":
     logger = helpers.get_logger()
 
-    main()
+    main()

recommendations/helpers.py

@@ -1,6 +1,4 @@
-from typing import Mapping
-from typing import Type
-from typing import List
+from typing import Dict
 from typing import Any
 
 from pathlib import Path
@@ -10,13 +8,13 @@
 import logging
 import pandas as pd
 
-from config import Config
 
-def clean_data(df: pd.DataFrame):
+def clean_data(df: pd.DataFrame) -> pd.DataFrame:
     df['product_name'] = df['product_name'].str.replace(',', '')
 
     return df
 
+
 def get_logger() -> logging.Logger:
     logger = logging.getLogger('')
     handler = logging.StreamHandler()
@@ -29,7 +27,7 @@ def get_logger() -> logging.Logger:
     return logger
 
 
-def get_configuration(config: str, configurations: Mapping[str, Type[Config]]) -> Type[Config]:
+def get_configuration(config: str, configurations: Dict[str, Any]) -> Any:
     try:
         configuration = configurations[config]
     except KeyError:

recommendations/insert_data.py

@@ -7,6 +7,7 @@
 import helpers
 import schema
 
+
 @click.command()
 @click.option('--file', default='production', help='the dataset to load to Postgres database')
 def main(file: str) -> None:
@@ -40,11 +41,11 @@ def main(file: str) -> None:
     with open(file_name, 'r') as f:
         next(f)
         cur.copy_from(f, table_name, sep=',')
-    
+
     conn.commit()
 
 
 if __name__ == "__main__":
     logger = helpers.get_logger()
 
-    main()
+    main()

recommendations/schema.py

@@ -18,8 +18,8 @@
                     department_id integer PRIMARY KEY,
                     department text
                 )
-            """
-        , 'dropquery': """DROP TABLE departments"""
+            """,
+        'dropquery': """DROP TABLE departments"""
     },
     'order_products_prior': {
         'filename': 'data/order_products__prior.csv',
@@ -76,4 +76,4 @@
             """,
         'dropquery': """DROP TABLE orders"""
     }
-}
+}