Fix lints in op-codegen

Fixes lints "renamed_and_removed_lints", "clippy::unnecessary_to_owned",
"clippy::manual_inspect", "ambiguous_glob_reexports".

Author: therealfrauholle

tensorflow-op-codegen/src/bin/eager.rs

@@ -10,11 +10,11 @@ use std::io::Write;
 use std::path::Path;
 use std::result::Result;
 use tensorflow_op_codegen::parser;
-use tensorflow_op_codegen::protos::OpDef;
+use tensorflow_op_codegen::protos::op_def::OpDef;
 
 use ::protobuf::ProtobufEnum;
-use tensorflow_op_codegen::protos::AttrValue_oneof_value;
-use tensorflow_op_codegen::protos::OpDef_ArgDef;
+use tensorflow_op_codegen::protos::attr_value::AttrValue_oneof_value;
+use tensorflow_op_codegen::protos::op_def::OpDef_ArgDef;
 
 #[derive(Clone)]
 struct Attr {
@@ -337,7 +337,7 @@ fn define_op<W: Write>(
     let mut attr_escaper = Escaper::new(keywords);
     for attr in op.attr.iter() {
         // skip if the attr is for type annotation
-        if skip_attrs.contains(&attr.get_name().to_string()) {
+        if skip_attrs.contains(attr.get_name()) {
             continue;
         }
 
@@ -637,14 +637,13 @@ fn main() -> Result<(), Box<dyn Error>> {
             .to_str()
             .ok_or("Unable to format path for tensorflow folder")?,
     )?;
-    let ops = parser::parse(&ops_bytes).map_err(|e| {
+    let ops = parser::parse(&ops_bytes).inspect_err(|e| {
         println!("Parse error at {:?}", e.pos);
         if let Some(p) = &e.pos {
             let input = String::from_utf8_lossy(&ops_bytes);
             println!("Previous: {}", &input[0..*p]);
             println!("Next: {}", &input[*p..]);
         }
-        e
     })?;
     let keywords: HashSet<String> = [
         "abstract",

tensorflow-op-codegen/src/main.rs

@@ -12,7 +12,7 @@ use std::io::Write;
 use std::path::Path;
 use std::result::Result;
 use tensorflow_op_codegen::parser;
-use tensorflow_op_codegen::protos::OpDef;
+use tensorflow_op_codegen::protos::op_def::OpDef;
 
 #[derive(Clone)]
 struct Attr {

tensorflow-op-codegen/src/parser.rs

@@ -2,18 +2,18 @@
 // currently implemented directly with nom to parse the text proto, but ideally this would use a
 // proto library with support for parsing text protos.
 
-use crate::protos::AttrValue;
-use crate::protos::AttrValue_ListValue;
-use crate::protos::DataType;
-use crate::protos::FullTypeDef;
-use crate::protos::FullTypeId;
-use crate::protos::OpDef;
-use crate::protos::OpDef_ArgDef;
-use crate::protos::OpDef_AttrDef;
-use crate::protos::OpDeprecation;
-use crate::protos::TensorProto;
-use crate::protos::TensorShapeProto;
-use crate::protos::TensorShapeProto_Dim;
+use crate::protos::attr_value::AttrValue;
+use crate::protos::attr_value::AttrValue_ListValue;
+use crate::protos::full_type::FullTypeDef;
+use crate::protos::full_type::FullTypeId;
+use crate::protos::op_def::OpDef;
+use crate::protos::op_def::OpDef_ArgDef;
+use crate::protos::op_def::OpDef_AttrDef;
+use crate::protos::op_def::OpDeprecation;
+use crate::protos::tensor::TensorProto;
+use crate::protos::tensor_shape::TensorShapeProto;
+use crate::protos::tensor_shape::TensorShapeProto_Dim;
+use crate::protos::types::DataType;
 use nom::branch::alt;
 use nom::bytes::complete::tag;
 use nom::character::complete::anychar;

tensorflow-op-codegen/src/protos/attr_value.rs

@@ -8,7 +8,6 @@
 #![allow(unused_attributes)]
 #![cfg_attr(rustfmt, rustfmt::skip)]
 
-#![allow(box_pointers)]
 #![allow(dead_code)]
 #![allow(missing_docs)]
 #![allow(non_camel_case_types)]

tensorflow-op-codegen/src/protos/full_type.rs

@@ -8,7 +8,6 @@
 #![allow(unused_attributes)]
 #![cfg_attr(rustfmt, rustfmt::skip)]
 
-#![allow(box_pointers)]
 #![allow(dead_code)]
 #![allow(missing_docs)]
 #![allow(non_camel_case_types)]

tensorflow-op-codegen/src/protos/mod.rs

@@ -1,20 +1,13 @@
-mod attr_value;
-pub use attr_value::*;
+pub mod attr_value;
 
-mod full_type;
-pub use full_type::*;
+pub mod full_type;
 
-mod op_def;
-pub use op_def::*;
+pub mod op_def;
 
-mod resource_handle;
-pub use resource_handle::*;
+pub mod resource_handle;
 
-mod tensor;
-pub use tensor::*;
+pub mod tensor;
 
-mod tensor_shape;
-pub use tensor_shape::*;
+pub mod tensor_shape;
 
-mod types;
-pub use types::*;
+pub mod types;

tensorflow-op-codegen/src/protos/op_def.rs

@@ -8,7 +8,6 @@
 #![allow(unused_attributes)]
 #![cfg_attr(rustfmt, rustfmt::skip)]
 
-#![allow(box_pointers)]
 #![allow(dead_code)]
 #![allow(missing_docs)]
 #![allow(non_camel_case_types)]

tensorflow-op-codegen/src/protos/resource_handle.rs

@@ -8,7 +8,6 @@
 #![allow(unused_attributes)]
 #![cfg_attr(rustfmt, rustfmt::skip)]
 
-#![allow(box_pointers)]
 #![allow(dead_code)]
 #![allow(missing_docs)]
 #![allow(non_camel_case_types)]

tensorflow-op-codegen/src/protos/tensor.rs

@@ -8,7 +8,6 @@
 #![allow(unused_attributes)]
 #![cfg_attr(rustfmt, rustfmt::skip)]
 
-#![allow(box_pointers)]
 #![allow(dead_code)]
 #![allow(missing_docs)]
 #![allow(non_camel_case_types)]

tensorflow-op-codegen/src/protos/tensor_shape.rs

@@ -8,7 +8,6 @@
 #![allow(unused_attributes)]
 #![cfg_attr(rustfmt, rustfmt::skip)]
 
-#![allow(box_pointers)]
 #![allow(dead_code)]
 #![allow(missing_docs)]
 #![allow(non_camel_case_types)]