Fix lint "elided_named_lifetimes"

And some dogfood.

Author: therealfrauholle

src/eager/op.rs

@@ -7,7 +7,7 @@ use libc::c_void;
 use libc::size_t;
 use std::ffi::{CStr, CString};
 use std::marker::PhantomData;
-use std::mem::{self, ManuallyDrop};
+use std::mem::ManuallyDrop;
 use std::os::raw::c_void as std_c_void;
 use std::ptr;
 
@@ -365,7 +365,7 @@ impl<'a> Op<'a> {
     /// For sync execution, if any of the inputs to `op` are not ready, this call
     /// will block till they become ready and then return when the kernel execution
     /// is done.
-    fn execute<const N: usize>(self, ctx: &'a Context) -> Result<[TensorHandle; N]> {
+    fn execute<const N: usize>(self, ctx: &'a Context) -> Result<[TensorHandle<'a>; N]> {
         let status = Status::new();
 
         let mut num_retvals = N as i32;
@@ -399,23 +399,8 @@ impl<'a> Op<'a> {
             return Err(status);
         }
 
-        let mut handles_uninit: [mem::MaybeUninit<TensorHandle>; N] =
-            unsafe { mem::MaybeUninit::uninit().assume_init() };
-
-        for i in 0..N {
-            let t = unsafe { TensorHandle::from_tensor_handle(ctx, retvals[i]) };
-            handles_uninit[i].write(t);
-        }
-
-        // Transmute uninitialized handles to initialized handles. Ideally, we would use
-        // `mem::transmute` here, but it is not stable yet for generic sized arrays.
-        // ref : https://github.com/rust-lang/rust/issues/61956
-        //
-        // Following is a workaround for this issue:
-        // Using &mut as an assertion of unique "ownership"
-        let ptr = &mut handles_uninit as *mut _ as *mut [TensorHandle; N];
-        let handles: [TensorHandle; N] = unsafe { ptr.read() };
-        mem::forget(handles_uninit);
+        let handles: [TensorHandle; N] =
+            std::array::from_fn(|i| unsafe { TensorHandle::from_tensor_handle(ctx, retvals[i]) });
 
         Ok(handles)
     }

src/eager/readonly_tensor.rs

@@ -1,11 +1,11 @@
+use crate::tf;
 use crate::{
     write_tensor_recursive, AnyTensor, DataType, Result, Shape, Tensor, TensorInner, TensorType,
 };
 use core::fmt;
 use fmt::{Debug, Formatter};
 use libc::c_int;
 use std::{fmt::Display, ops::Deref};
-use tensorflow_sys as tf;
 
 /// A read-only tensor.
 ///

src/eager/tensor_handle.rs

@@ -64,7 +64,7 @@ use crate::{AnyTensor, DataType, Result, Status, TensorType};
 #[derive(Debug)]
 pub struct TensorHandle<'a> {
     pub(super) inner: *mut tf::TFE_TensorHandle,
-    // TensorHandle should not live longer than a given context.
+    // TensorHandle canjot outlive its associated context
     ctx: PhantomData<&'a Context>,
 }