Skip to content

Commit 940d415

Browse files
Fix Pad op translation (#660)
* Use helper ConstructNgNode for constructing nodes in the Pad translation * Use vector<int64> to represent paddings as nGraph can internally convert to CoordinateDiff if necessary
1 parent 72b220b commit 940d415

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

ngraph_bridge/ngraph_builder.cc

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2265,25 +2265,24 @@ static Status TranslatePadOp(const Node* op,
22652265
}
22662266

22672267
// Set pads_begin & pads_end (from the pad_val_op)
2268-
shared_ptr<opset::Constant> pads_begin_node, pads_end_node;
22692268
std::vector<int64> paddings;
22702269
TF_RETURN_IF_ERROR(GetStaticInputVector(op, 1, static_input_map, &paddings));
2271-
NGRAPH_VLOG(6) << op->name() << " pads {" << ng::join(paddings) << "}";
2270+
NGRAPH_VLOG(3) << op->name() << " pads {" << ng::join(paddings) << "}";
22722271
if (paddings.size() % 2 != 0) {
22732272
return errors::InvalidArgument(
22742273
"Constant node for paddings does not have an even number of "
22752274
"elements");
22762275
}
2277-
ng::CoordinateDiff pad_begin(paddings.size() / 2);
2278-
ng::CoordinateDiff pad_end(paddings.size() / 2);
2276+
std::vector<int64> pad_begin(paddings.size() / 2);
2277+
std::vector<int64> pad_end(paddings.size() / 2);
22792278
for (size_t i = 0; i < paddings.size() / 2; i++) {
22802279
pad_begin[i] = paddings[2 * i];
22812280
pad_end[i] = paddings[2 * i + 1];
22822281
}
2283-
pads_begin_node = make_shared<opset::Constant>(
2284-
ng::element::i64, ng::Shape{pad_begin.size()}, pad_begin);
2285-
pads_end_node = make_shared<opset::Constant>(
2286-
ng::element::i64, ng::Shape{pad_end.size()}, pad_end);
2282+
auto pads_begin_node = ConstructNgNode<opset::Constant>(
2283+
op->name(), ng::element::i64, ng::Shape{pad_begin.size()}, pad_begin);
2284+
auto pads_end_node = ConstructNgNode<opset::Constant>(
2285+
op->name(), ng::element::i64, ng::Shape{pad_end.size()}, pad_end);
22872286

22882287
// Create final Op
22892288
result_pad_op =

0 commit comments

Comments
 (0)