fix: monitor - throw multi errors hidden in array (#1119)

* fix: monitor - throw multi errors hidden in array

* fix: monitor - read type error fields

Author: Kagashino

go.mod

@@ -10,6 +10,8 @@ require (
 	github.com/fatih/color v1.9.0
 	github.com/golangci/golangci-lint v1.27.0
 	github.com/google/go-querystring v1.1.0 // indirect
+	github.com/hashicorp/errwrap v1.1.0 // indirect
+	github.com/hashicorp/go-multierror v1.1.1
 	github.com/hashicorp/hcl/v2 v2.6.0
 	github.com/hashicorp/terraform-plugin-sdk v1.14.0
 	github.com/katbyte/terrafmt v0.2.0

go.sum

@@ -204,6 +204,8 @@ github.com/grpc-ecosystem/grpc-gateway v1.9.0/go.mod h1:vNeuVxBJEsws4ogUvrchl83t
 github.com/hashicorp/errwrap v0.0.0-20180715044906-d6c0cd880357/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/errwrap v1.0.0 h1:hLrqtEDnRye3+sgx6z4qVLNuviH3MR5aQ0ykNJa/UYA=
 github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
+github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY2I=
+github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-cleanhttp v0.5.0/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
 github.com/hashicorp/go-cleanhttp v0.5.1 h1:dH3aiDG9Jvb5r5+bYHsikaOUIpcM0xvgMXVoDkXMzJM=
 github.com/hashicorp/go-cleanhttp v0.5.1/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
@@ -215,6 +217,8 @@ github.com/hashicorp/go-hclog v0.9.2/go.mod h1:5CU+agLiy3J7N7QjHK5d05KxGsuXiQLrj
 github.com/hashicorp/go-multierror v0.0.0-20180717150148-3d5d8f294aa0/go.mod h1:JMRHfdO9jKNzS/+BTlxCjKNQHg/jZAft8U7LloJvN7I=
 github.com/hashicorp/go-multierror v1.0.0 h1:iVjPR7a6H0tWELX5NxNe7bYopibicUzc7uPribsnS6o=
 github.com/hashicorp/go-multierror v1.0.0/go.mod h1:dHtQlpGsu+cZNNAkkCN/P3hoUDHhCYQXV3UM06sGGrk=
+github.com/hashicorp/go-multierror v1.1.1 h1:H5DkEtf6CXdFp0N0Em5UCwQpXMWke8IA0+lD48awMYo=
+github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9/fmwbPZ6JB6eMoM=
 github.com/hashicorp/go-plugin v1.0.1/go.mod h1:++UyYGoz3o5w9ZzAdZxtQKrWWP+iqPBn3cQptSMzBuY=
 github.com/hashicorp/go-plugin v1.2.0 h1:CUfYokW0EJNDcGecVrHZK//Cp1GFlHwoqtcUIEiU6BY=
 github.com/hashicorp/go-plugin v1.2.0/go.mod h1:F9eH4LrE/ZsRdbwhfjs9k9HoDUwAHnYtXdgmf1AVNs0=

tencentcloud/resource_tc_monitor_alarm_policy.go

@@ -226,6 +226,10 @@ package tencentcloud
 import (
 	"fmt"
 	"log"
+	"strconv"
+	"time"
+
+	"github.com/hashicorp/go-multierror"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
@@ -735,11 +739,26 @@ func resourceTencentMonitorAlarmPolicyRead(d *schema.ResourceData, meta interfac
 		d.Set("remark", policy.Remark),
 		d.Set("enable", policy.Enable),
 		d.Set("project_id", policy.ProjectId),
-		d.Set("conditon_template_id", policy.ConditionTemplateId),
-		d.Set("create_time", policy.InsertTime),
-		d.Set("update_time", policy.UpdateTime),
 	)
 
+	if policy.ConditionTemplateId != nil && *policy.ConditionTemplateId != "" {
+		id, err := strconv.ParseInt(*policy.ConditionTemplateId, 10, 64)
+		if id != 0 && err == nil {
+			errs = append(errs, d.Set("conditon_template_id", id))
+		}
+	}
+
+	if policy.InsertTime != nil {
+		t := time.Unix(*policy.InsertTime, 0)
+		tFmt := t.Format("2006-01-02 15:04:05")
+		errs = append(errs, d.Set("create_time", tFmt))
+	}
+	if policy.UpdateTime != nil {
+		t := time.Unix(*policy.UpdateTime, 0)
+		tFmt := t.Format("2006-01-02 15:04:05")
+		errs = append(errs, d.Set("update_time", tFmt))
+	}
+
 	var rules = make([]interface{}, 0, 100)
 	for _, rule := range policy.Condition.Rules {
 
@@ -832,11 +851,14 @@ func resourceTencentMonitorAlarmPolicyRead(d *schema.ResourceData, meta interfac
 	}
 	_ = d.Set("policy_tag", tagSets)
 
-	if len(errs) > 0 {
-		return errs[0]
-	} else {
-		return nil
+	var errResults *multierror.Error
+	for i := range errs {
+		err := errs[i]
+		if err != nil {
+			errResults = multierror.Append(errResults, err)
+		}
 	}
+	return errResults.ErrorOrNil()
 }
 
 func resourceTencentMonitorAlarmPolicyUpdate(d *schema.ResourceData, meta interface{}) error {