Skip to content

Commit af66046

Browse files
author
hhermanwang
committed
modify code review
1 parent dede7e4 commit af66046

File tree

5 files changed

+3
-7
lines changed

5 files changed

+3
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## 1.48.1 (Unreleased)
1+
## 1.49.0 (Unreleased)
22

33
FEATURES:
44

examples/tencentcloud-cos/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ variable "policy" {
3131
],
3232
"Effect": "allow",
3333
"Resource": [
34-
"qcs::cos:ap-nanjing:uid/1259649581:hhermanwang-1259649581/*"
34+
"*"
3535
]
3636
}
3737
]

tencentcloud/resource_tc_clb_listener.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ func resourceTencentCloudClbListener() *schema.Resource {
352352
Type: schema.TypeString,
353353
Optional: true,
354354
ForceNew: true,
355-
Computed: true,
356355
ValidateFunc: validateAllowedStringValue([]string{CLB_TARGET_TYPE_NODE, CLB_TARGET_TYPE_TARGETGROUP}),
357356
Description: "Backend target type. Valid values: `NODE`, `TARGETGROUP`. `NODE` means to bind ordinary nodes, `TARGETGROUP` means to bind target group. NOTES: TCP/UDP/TCP_SSL listener must configuration, HTTP/HTTPS listener needs to be configured in tencentcloud_clb_listener_rule.",
358357
},

tencentcloud/resource_tc_cos_bucket_policy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func resourceTencentCloudCosBucketPolicy() *schema.Resource {
9090
flag := reflect.DeepEqual(oldJson, newJson)
9191
return flag
9292
},
93-
Description: "The text of the policy. this field is required. the syntax refers to https://cloud.tencent.com/document/product/436/18023.",
93+
Description: "The text of the policy. for more info please refer to [Tencent official doc](https://intl.cloud.tencent.com/document/product/436/18023).",
9494
},
9595
},
9696
}

tencentcloud/resource_tc_kubernetes_as_scaling_group.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -894,9 +894,6 @@ func resourceKubernetesAsScalingGroupUpdate(d *schema.ResourceData, meta interfa
894894
asGroupId := items[1]
895895
if d.HasChange("auto_scaling_group") {
896896
asGroups := d.Get("auto_scaling_group").([]interface{})
897-
if len(asGroups) != 1 {
898-
return fmt.Errorf("need only one auto_scaling_group")
899-
}
900897
for _, d := range asGroups {
901898
value := d.(map[string]interface{})
902899
maxSize := int64(value["max_size"].(int))

0 commit comments

Comments
 (0)