Fix/eks lb modify (#985)

* fix: eks lb change type error

* fix: eks - lb modified problems

Author: Kagashino

tencentcloud/resource_tc_eks_cluster.go

@@ -551,8 +551,7 @@ func resourceTencentcloudEKSClusterUpdate(d *schema.ResourceData, meta interface
 	enablePublic := false
 	if d.HasChange("internal_lb") {
 		updateAttrs = append(updateAttrs, "internal_lb")
-		if v, ok := d.GetOk("internal_lb"); ok {
-			lb := v.([]map[string]interface{})[0]
+		if lb, ok := helper.InterfacesHeadMap(d, "internal_lb"); ok {
 			enabled := lb["enabled"].(bool)
 			request.InternalLB = &tke.ClusterInternalLB{
 				Enabled: &enabled,
@@ -570,8 +569,7 @@ func resourceTencentcloudEKSClusterUpdate(d *schema.ResourceData, meta interface
 
 	if d.HasChange("public_lb") {
 		updateAttrs = append(updateAttrs, "public_lb")
-		if v, ok := d.GetOk("public_lb"); ok {
-			lb := v.([]map[string]interface{})[0]
+		if lb, ok := helper.InterfacesHeadMap(d, "public_lb"); ok {
 			enabled := lb["enabled"].(bool)
 			request.PublicLB = &tke.ClusterPublicLB{
 				Enabled: &enabled,
@@ -591,8 +589,15 @@ func resourceTencentcloudEKSClusterUpdate(d *schema.ResourceData, meta interface
 				Enabled: helper.Bool(false),
 			}
 		}
+	}
 
-		err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
+	if len(updateAttrs) > 0 {
+		err := service.UpdateEksCluster(ctx, request)
+		if err != nil {
+			return err
+		}
+
+		err = resource.Retry(readRetryTimeout, func() *resource.RetryError {
 			info, inErr := service.DescribeEKSClusterCredentialById(ctx, id)
 			if inErr != nil {
 				return retryError(inErr)
@@ -610,17 +615,6 @@ func resourceTencentcloudEKSClusterUpdate(d *schema.ResourceData, meta interface
 		if err != nil {
 			return err
 		}
-
-	}
-
-	if len(updateAttrs) > 0 {
-		err := service.UpdateEksCluster(ctx, request)
-		if err != nil {
-			return err
-		}
-		for _, attr := range updateAttrs {
-			d.SetPartial(attr)
-		}
 	}
 
 	if d.HasChange("tags") {

tencentcloud/resource_tc_eks_cluster_test.go

@@ -82,7 +82,7 @@ func TestAccTencentCloudEKSCluster_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "dns_servers.0.servers.#", "2"),
 					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "dns_servers.0.servers.0", "10.0.0.1:82"),
 					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "dns_servers.0.servers.1", "10.0.0.1:83"),
-					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "enable_vpc_core_dns", "false"),
+					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "enable_vpc_core_dns", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "need_delete_cbs", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "internal_lb.0.enabled", "true"),
 					resource.TestCheckResourceAttr("tencentcloud_eks_cluster.foo", "public_lb.0.enabled", "true"),
@@ -217,7 +217,7 @@ resource "tencentcloud_eks_cluster" "foo" {
     domain = "example1.org"
     servers = ["10.0.0.1:82", "10.0.0.1:83"]
   }
-  enable_vpc_core_dns = false
+  enable_vpc_core_dns = true
   need_delete_cbs = true
   internal_lb {
     enabled = true