add resource binding alarm polciy (#729)

Author: hellertang

tencentcloud/provider.go

@@ -373,6 +373,7 @@ Monitor
   Resource
     tencentcloud_monitor_policy_group
     tencentcloud_monitor_binding_object
+	tencentcloud_monitor_policy_binding_object
     tencentcloud_monitor_binding_receiver
 	tencentcloud_monitor_alarm_policy
 
@@ -934,6 +935,7 @@ func Provider() terraform.ResourceProvider {
 			"tencentcloud_cdn_domain":                              resourceTencentCloudCdnDomain(),
 			"tencentcloud_monitor_policy_group":                    resourceTencentMonitorPolicyGroup(),
 			"tencentcloud_monitor_binding_object":                  resourceTencentMonitorBindingObject(),
+			"tencentcloud_monitor_policy_binding_object":           resourceTencentMonitorPolicyBindingObject(),
 			"tencentcloud_monitor_binding_receiver":                resourceTencentMonitorBindingAlarmReceiver(),
 			"tencentcloud_monitor_alarm_policy":                    resourceTencentMonitorAlarmPolicy(),
 			"tencentcloud_mongodb_standby_instance":                resourceTencentCloudMongodbStandbyInstance(),
@@ -1056,6 +1058,5 @@ func providerConfigure(d *schema.ResourceData) (interface{}, error) {
 			*response.Response.Credentials.Token,
 		)
 	}
-
 	return &tcClient, nil
 }

tencentcloud/resource_tc_monitor_alarm_policy.go

@@ -101,19 +101,19 @@ func AlarmPolicyRule() map[string]*schema.Schema {
 		"description": {
 			Type:        schema.TypeString,
 			Optional:    true,
-			ForceNew:    true,
+			Computed:    true,
 			Description: "Metric display name, which is used in the output parameter.",
 		},
 		"unit": {
 			Type:        schema.TypeString,
 			Optional:    true,
-			ForceNew:    true,
+			Computed:    true,
 			Description: "Unit, which is used in the output parameter.",
 		},
 		"rule_type": {
 			Type:        schema.TypeString,
 			Optional:    true,
-			ForceNew:    true,
+			Computed:    true,
 			Description: "Trigger condition type.",
 		},
 	}

tencentcloud/resource_tc_monitor_binding_object.go

@@ -1,6 +1,8 @@
 /*
 Provides a resource for bind objects to a policy group resource.
 
+~> **NOTE:** It has been deprecated and replaced by tencentcloud_monitor_policy_binding_object.
+
 Example Usage
 
 ```hcl
@@ -50,6 +52,7 @@ import (
 
 func resourceTencentMonitorBindingObject() *schema.Resource {
 	return &schema.Resource{
+		DeprecationMessage: "This resource has been deprecated in Terraform TencentCloud provider version 1.60.5. Please use 'tencentcloud_monitor_policy_binding_object' instead.",
 		Create: resourceTencentMonitorBindingObjectCreate,
 		Read:   resourceTencentMonitorBindingObjectRead,
 		Delete: resourceTencentMonitorBindingObjectDelete,

tencentcloud/resource_tc_monitor_policy_binding_object.go

@@ -0,0 +1,327 @@
+/*
+Provides a resource for bind objects to a alarm policy resource.
+
+Example Usage
+
+```hcl
+data "tencentcloud_instances" "instances" {
+}
+resource "tencentcloud_monitor_alarm_policy" "policy" {
+  policy_name = "hello"
+  monitor_type = "MT_QCE"
+  enable = 1
+  project_id = 1244035
+  namespace = "cvm_device"
+
+  conditions {
+    is_union_rule = 1
+    rules {
+      metric_name = "CpuUsage"
+      period = 60
+      operator = "ge"
+      value = "89.9"
+      continue_period = 1
+      notice_frequency = 3600
+      is_power_notice = 0
+    }
+  }
+
+  event_conditions {
+    metric_name = "ping_unreachable"
+  }
+
+  event_conditions {
+    metric_name = "guest_reboot"
+  }
+
+  notice_ids = ["notice-l9ziyxw6"]
+
+  trigger_tasks {
+    type = "AS"
+    task_config = "{\"Region\":\"ap-guangzhou\",\"Group\":\"asg-0z312312x\",\"Policy\":\"asp-ganig28\"}"
+  }
+
+}
+
+#for cvm
+resource "tencentcloud_monitor_policy_binding_object" "binding" {
+  policy_id = tencentcloud_monitor_alarm_policy.policy.id
+
+  dimensions {
+    dimensions_json = "{\"unInstanceId\":\"${data.tencentcloud_instances.instances.instance_list[0].instance_id}\"}"
+  }
+}
+```
+
+*/
+package tencentcloud
+
+import (
+	"context"
+	"encoding/json"
+	"fmt"
+	"time"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/hashcode"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+	monitor "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/monitor/v20180724"
+	"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper"
+	"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/ratelimit"
+)
+
+func resourceTencentMonitorPolicyBindingObject() *schema.Resource {
+	return &schema.Resource{
+		Create: resourceTencentMonitorPolicyBindingObjectCreate,
+		Read:   resourceTencentMonitorPolicyBindingObjectRead,
+		Delete: resourceTencentMonitorPolicyBindingObjectDelete,
+		Schema: map[string]*schema.Schema{
+			"policy_id": {
+				Type:        schema.TypeString,
+				Required:    true,
+				ForceNew:    true,
+				Description: "Alarm policy ID for binding objects.",
+			},
+			"dimensions": {
+				Type:        schema.TypeSet,
+				Required:    true,
+				ForceNew:    true,
+				Description: "A list objects. Each element contains the following attributes:",
+				Set: func(v interface{}) int {
+					vmap := v.(map[string]interface{})
+					hashMap := map[string]interface{}{}
+					if vmap["dimensions_json"] != nil {
+						hashMap["dimensions_json"] = vmap["dimensions_json"]
+					}
+					b, _ := json.Marshal(hashMap)
+					return hashcode.String(string(b))
+				},
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"dimensions_json": {
+							Type:        schema.TypeString,
+							Required:    true,
+							ForceNew:    true,
+							Description: `Represents a collection of dimensions of an object instance, json format.eg:'{"unInstanceId":"ins-ot3cq4bi"}'.`,
+						},
+						"unique_id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "Object unique ID.",
+						},
+					},
+				},
+			},
+		},
+	}
+}
+
+func resourceTencentMonitorPolicyBindingObjectCreate(d *schema.ResourceData, meta interface{}) error {
+	defer logElapsed("resource.tencentcloud_monitor_binding_object.create")()
+
+	var (
+		logId          = getLogId(contextNil)
+		ctx            = context.WithValue(context.TODO(), logIdKey, logId)
+		monitorService = MonitorService{client: meta.(*TencentCloudClient).apiV3Conn}
+		request        = monitor.NewBindingPolicyObjectRequest()
+		idSeeds        []string
+		policyId       = d.Get("policy_id").(string)
+	)
+
+	info, err := monitorService.DescribeAlarmPolicyById(ctx, policyId)
+	if err != nil {
+		return err
+	}
+	if info == nil {
+		return fmt.Errorf("alarm policy %s not exist", policyId)
+	}
+	request.GroupId = helper.Int64(0)
+	request.PolicyId = &policyId
+	dimensions := d.Get("dimensions").(*schema.Set).List()
+
+	request.Dimensions = make([]*monitor.BindingPolicyObjectDimension, 0, len(dimensions))
+
+	idSeeds = append(idSeeds, fmt.Sprintf("%s", policyId))
+
+	for _, v := range dimensions {
+		m := v.(map[string]interface{})
+		var dimension monitor.BindingPolicyObjectDimension
+		var dimensionsJson = m["dimensions_json"].(string)
+		var region = MonitorRegionMap[monitorService.client.Region]
+
+		if region == "" {
+			return fmt.Errorf("monitor not support region `%s` bind", monitorService.client.Region)
+		}
+		idSeeds = append(idSeeds, dimensionsJson, region)
+		dimension.Dimensions = &dimensionsJson
+		dimension.Region = &region
+		request.Dimensions = append(request.Dimensions, &dimension)
+	}
+
+	request.Module = helper.String("monitor")
+	if err = resource.Retry(writeRetryTimeout, func() *resource.RetryError {
+		ratelimit.Check(request.GetAction())
+		if _, err = monitorService.client.UseMonitorClient().BindingPolicyObject(request); err != nil {
+			return retryError(err, InternalError)
+		}
+		return nil
+	}); err != nil {
+		return err
+	}
+
+	d.SetId(helper.DataResourceIdsHash(idSeeds))
+	time.Sleep(3 * time.Second)
+
+	objects, err := monitorService.DescribeBindingAlarmPolicyObjectList(ctx, policyId)
+
+	if err != nil {
+		return err
+	}
+
+	successDimensionsJsonMap := make(map[string]bool)
+	bindingFails := make([]string, 0, len(request.Dimensions))
+	for _, v := range objects {
+		successDimensionsJsonMap[*v.Dimensions] = true
+	}
+	for _, v := range request.Dimensions {
+		if !successDimensionsJsonMap[*v.Dimensions] {
+			bindingFails = append(bindingFails, *v.Dimensions)
+		}
+	}
+
+	if len(bindingFails) > 0 {
+		return fmt.Errorf("bind objects to policy has partial failure,Please check if it is an instance of this region `%s`,[%s]",
+			monitorService.client.Region, helper.SliceFieldSerialize(bindingFails))
+	}
+
+	return resourceTencentMonitorPolicyBindingObjectRead(d, meta)
+}
+
+func resourceTencentMonitorPolicyBindingObjectRead(d *schema.ResourceData, meta interface{}) error {
+	defer logElapsed("resource.tencentcloud_monitor_policy_binding_object.read")()
+	defer inconsistentCheck(d, meta)()
+	var (
+		logId          = getLogId(contextNil)
+		ctx            = context.WithValue(context.TODO(), logIdKey, logId)
+		monitorService = MonitorService{client: meta.(*TencentCloudClient).apiV3Conn}
+		policyId       = d.Get("policy_id").(string)
+	)
+
+	info, err := monitorService.DescribeAlarmPolicyById(ctx, policyId)
+	if err != nil {
+		return err
+	}
+	if info == nil {
+		return fmt.Errorf("alarm policy %s not exist", policyId)
+	}
+
+	objects, err := monitorService.DescribeBindingAlarmPolicyObjectList(ctx, policyId)
+
+	if err != nil {
+		return err
+	}
+
+	getUniqueId := func(dimensionsJson string) (has bool, uniqueId string) {
+		for _, item := range objects {
+			if *item.Dimensions == dimensionsJson {
+				uniqueId = *item.UniqueId
+				has = true
+				return
+			}
+		}
+		return
+	}
+
+	dimensions := d.Get("dimensions").(*schema.Set).List()
+	newDimensions := make([]interface{}, 0, len(dimensions))
+
+	for _, v := range dimensions {
+		m := v.(map[string]interface{})
+		var dimensionsJson = m["dimensions_json"].(string)
+		var has, uniqueId = getUniqueId(dimensionsJson)
+		if has {
+			newDimensions = append(newDimensions, map[string]interface{}{
+				"dimensions_json": dimensionsJson,
+				"unique_id":       uniqueId,
+			})
+		}
+	}
+
+	if len(newDimensions) == 0 {
+		d.SetId("")
+		return nil
+	}
+
+	return d.Set("dimensions", newDimensions)
+}
+
+func resourceTencentMonitorPolicyBindingObjectDelete(d *schema.ResourceData, meta interface{}) error {
+	defer logElapsed("resource.tencentcloud_monitor_binding_object.delete")()
+
+	var (
+		logId          = getLogId(contextNil)
+		ctx            = context.WithValue(context.TODO(), logIdKey, logId)
+		monitorService = MonitorService{client: meta.(*TencentCloudClient).apiV3Conn}
+		policyId       = d.Get("policy_id").(string)
+	)
+
+	info, err := monitorService.DescribeAlarmPolicyById(ctx, policyId)
+	if err != nil {
+		return err
+	}
+	if info == nil {
+		return fmt.Errorf("alarm policy %s not exist", policyId)
+	}
+
+	objects, err := monitorService.DescribeBindingAlarmPolicyObjectList(ctx, policyId)
+
+	if err != nil {
+		return err
+	}
+	getUniqueId := func(dimensionsJson string) (has bool, uniqueId string) {
+		for _, item := range objects {
+			if *item.Dimensions == dimensionsJson {
+				uniqueId = *item.UniqueId
+				has = true
+				return
+			}
+		}
+		return
+	}
+
+	dimensions := d.Get("dimensions").(*schema.Set).List()
+	uniqueIds := make([]*string, 0, len(dimensions))
+	for _, v := range dimensions {
+		m := v.(map[string]interface{})
+		var dimensionsJson = m["dimensions_json"].(string)
+		var has, uniqueId = getUniqueId(dimensionsJson)
+		if has {
+			uniqueIds = append(uniqueIds, &uniqueId)
+		}
+	}
+
+	if len(uniqueIds) == 0 {
+		d.SetId("")
+		return nil
+	}
+
+	var (
+		request = monitor.NewUnBindingPolicyObjectRequest()
+	)
+
+	request.Module = helper.String("monitor")
+	request.GroupId = helper.Int64(0)
+	request.PolicyId = &policyId
+	request.UniqueId = uniqueIds
+
+	if err = resource.Retry(writeRetryTimeout, func() *resource.RetryError {
+		ratelimit.Check(request.GetAction())
+		if _, err = monitorService.client.UseMonitorClient().UnBindingPolicyObject(request); err != nil {
+			return retryError(err, InternalError)
+		}
+		return nil
+	}); err != nil {
+		return err
+	}
+	return nil
+}