fix: cam unit-test (#852)

Co-authored-by: mikatong <[email protected]>

Author: tongyiming

tencentcloud/data_source_tc_cam_policies_test.go

@@ -18,11 +18,10 @@ func TestAccTencentCloudCamPoliciesDataSource_basic(t *testing.T) {
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckCamPolicyExists("tencentcloud_cam_policy.policy"),
 					resource.TestCheckResourceAttr("data.tencentcloud_cam_policies.policies", "policy_list.#", "1"),
-					resource.TestCheckResourceAttr("data.tencentcloud_cam_policies.policies", "policy_list.0.name", "cam-policy-test5"),
+					resource.TestCheckResourceAttr("data.tencentcloud_cam_policies.policies", "policy_list.0.name", "cam-policy-test55"),
 					resource.TestCheckResourceAttr("data.tencentcloud_cam_policies.policies", "policy_list.0.description", "test"),
 					resource.TestCheckResourceAttrSet("data.tencentcloud_cam_policies.policies", "policy_list.0.attachments"),
 					resource.TestCheckResourceAttrSet("data.tencentcloud_cam_policies.policies", "policy_list.0.create_time"),
-					resource.TestCheckResourceAttrSet("data.tencentcloud_cam_policies.policies", "policy_list.0.service_type"),
 					resource.TestCheckResourceAttrSet("data.tencentcloud_cam_policies.policies", "policy_list.0.create_mode"),
 					resource.TestCheckResourceAttrSet("data.tencentcloud_cam_policies.policies", "policy_list.0.policy_id"),
 				),
@@ -33,7 +32,7 @@ func TestAccTencentCloudCamPoliciesDataSource_basic(t *testing.T) {
 
 const testAccCamPoliciesDataSource_basic = `
 resource "tencentcloud_cam_policy" "policy" {
-  name        = "cam-policy-test5"
+  name        = "cam-policy-test55"
   document    = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"resource\":[\"*\"]}]}"
   description = "test"
 }

tencentcloud/data_source_tc_cam_role_policy_attachments_test.go

@@ -1,6 +1,7 @@
 package tencentcloud
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
@@ -14,7 +15,7 @@ func TestAccTencentCloudCamRolePolicyAttachmentsDataSource_basic(t *testing.T) {
 		CheckDestroy: testAccCheckCamRolePolicyAttachmentDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCamRolePolicyAttachmentsDataSource_basic,
+				Config: testAccCamRolePolicyAttachmentsDataSource_basic(ownerUin),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckCamRolePolicyAttachmentExists("tencentcloud_cam_role_policy_attachment.role_policy_attachment"),
 					resource.TestCheckResourceAttr("data.tencentcloud_cam_role_policy_attachments.role_policy_attachments", "role_policy_attachment_list.#", "1"),
@@ -28,10 +29,11 @@ func TestAccTencentCloudCamRolePolicyAttachmentsDataSource_basic(t *testing.T) {
 	})
 }
 
-const testAccCamRolePolicyAttachmentsDataSource_basic = `
+func testAccCamRolePolicyAttachmentsDataSource_basic(uin string) string {
+	return fmt.Sprintf(`
 resource "tencentcloud_cam_role" "role" {
   name          = "cam-role-test"
-  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/100009461222:uin/100009461222\"]}}]}"
+  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/%s:uin/%s\"]}}]}"
   description   = "test"
   console_login = true
 }
@@ -49,5 +51,5 @@ resource "tencentcloud_cam_role_policy_attachment" "role_policy_attachment" {
   
 data "tencentcloud_cam_role_policy_attachments" "role_policy_attachments" {
   role_id = tencentcloud_cam_role_policy_attachment.role_policy_attachment.role_id
+}`, uin, uin)
 }
-`

tencentcloud/data_source_tc_cam_roles_test.go

@@ -1,6 +1,7 @@
 package tencentcloud
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
@@ -14,7 +15,7 @@ func TestAccTencentCloudCamRolesDataSource_basic(t *testing.T) {
 		CheckDestroy: testAccCheckCamRoleDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCamRolesDataSource_basic,
+				Config: testAccCamRolesDataSource_basic(ownerUin),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckCamRoleExists("tencentcloud_cam_role.role"),
 					resource.TestCheckResourceAttr("data.tencentcloud_cam_roles.roles", "role_list.#", "1"),
@@ -31,15 +32,16 @@ func TestAccTencentCloudCamRolesDataSource_basic(t *testing.T) {
 	})
 }
 
-const testAccCamRolesDataSource_basic = `
+func testAccCamRolesDataSource_basic(uin string) string {
+	return fmt.Sprintf(`
 resource "tencentcloud_cam_role" "role" {
   name          = "cam-role-test11"
-  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/100009461222:uin/100009461222\"]}}]}"
+  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/%s:uin/%s\"]}}]}"
   description   = "test"
   console_login = true
 }
   
 data "tencentcloud_cam_roles" "roles" {
   role_id = tencentcloud_cam_role.role.id
+}`, uin, uin)
 }
-`

tencentcloud/resource_tc_cam_role_policy_attachment_test.go

@@ -17,7 +17,7 @@ func TestAccTencentCloudCamRolePolicyAttachment_basic(t *testing.T) {
 		CheckDestroy: testAccCheckCamRolePolicyAttachmentDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCamRolePolicyAttachment_basic,
+				Config: testAccCamRolePolicyAttachment_basic(ownerUin),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCamRolePolicyAttachmentExists("tencentcloud_cam_role_policy_attachment.role_policy_attachment_basic"),
 					resource.TestCheckResourceAttrSet("tencentcloud_cam_role_policy_attachment.role_policy_attachment_basic", "role_id"),
@@ -80,10 +80,11 @@ func testAccCheckCamRolePolicyAttachmentExists(n string) resource.TestCheckFunc
 }
 
 //need to add policy resource definition
-const testAccCamRolePolicyAttachment_basic = `
+func testAccCamRolePolicyAttachment_basic(uin string) string {
+	return fmt.Sprintf(`
 resource "tencentcloud_cam_role" "role" {
   name          = "cam-role-test"
-  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/100009461222:uin/100009461222\"]}}]}"
+  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/%s:uin/%s\"]}}]}"
   description   = "test"
   console_login = true
 }
@@ -97,5 +98,5 @@ resource "tencentcloud_cam_policy" "policy" {
 resource "tencentcloud_cam_role_policy_attachment" "role_policy_attachment_basic" {
   role_id   = tencentcloud_cam_role.role.id
   policy_id = tencentcloud_cam_policy.policy.id
+}`, uin, uin)
 }
-`

tencentcloud/resource_tc_cam_role_test.go

@@ -17,14 +17,14 @@ func TestAccTencentCloudCamRole_basic(t *testing.T) {
 		CheckDestroy: testAccCheckCamRoleDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCamRole_basic,
+				Config: testAccCamRole_basic(ownerUin),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCamRoleExists("tencentcloud_cam_role.role_basic"),
 					resource.TestCheckResourceAttrSet("tencentcloud_cam_role.role_basic", "name"),
 					resource.TestCheckResourceAttrSet("tencentcloud_cam_role.role_basic", "document"),
 				),
 			}, {
-				Config: testAccCamRole_update,
+				Config: testAccCamRole_update(ownerUin),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckCamRoleExists("tencentcloud_cam_role.role_basic"),
 					resource.TestCheckResourceAttrSet("tencentcloud_cam_role.role_basic", "name"),
@@ -86,19 +86,21 @@ func testAccCheckCamRoleExists(n string) resource.TestCheckFunc {
 	}
 }
 
-const testAccCamRole_basic = `
+func testAccCamRole_basic(uin string) string {
+	return fmt.Sprintf(`
 resource "tencentcloud_cam_role" "role_basic" {
-  name          = "cam-role-test1"
-  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/100009461222:uin/100009461222\"]}}]}"
-  description   = "test"
-  console_login = true
+	name          = "cam-role-test1"
+	document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/%s:uin/%s\"]}}]}"
+	description   = "test"
+	console_login = true
+}`, uin, uin)
 }
-`
 
-const testAccCamRole_update = `
+func testAccCamRole_update(uin string) string {
+	return fmt.Sprintf(`
 resource "tencentcloud_cam_role" "role_basic" {
   name          = "cam-role-test1"
-  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/100009461222:uin/100009461222\"]}},{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/100009461222:uin/100009461222\"]}}]}"
+  document      = "{\"version\":\"2.0\",\"statement\":[{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/%s:uin/%s\"]}},{\"action\":[\"name/sts:AssumeRole\"],\"effect\":\"allow\",\"principal\":{\"qcs\":[\"qcs::cam::uin/%s:uin/%s\"]}}]}"
   console_login = false
+}`, uin, uin, uin, uin)
 }
-`