nits

Author: THardy98

packages/workflow/src/interfaces.ts

@@ -541,7 +541,7 @@ export type DefaultSignalHandler = (signalName: string, ...args: unknown[]) => v
 /**
  * A handler function accepting update calls for non-registered update names.
  */
-export type DefaultUpdateHandler = (updateName: string, ...args: any[]) => Promise<any> | any;
+export type DefaultUpdateHandler = (updateName: string, ...args: unknown[]) => Promise<unknown> | unknown;
 
 /**
  * A validation function capable of accepting the arguments for a given UpdateDefinition.

packages/workflow/src/internals.ts

@@ -671,21 +671,24 @@ export class Activator implements ActivationHandler {
     if (!protocolInstanceId) {
       throw new TypeError('Missing activation update protocolInstanceId');
     }
-    if (!this.updateHandlers.get(name) && !this.defaultUpdateHandler) {
+
+    const entry =
+      this.updateHandlers.get(name) ??
+      (this.defaultUpdateHandler
+        ? {
+            handler: this.defaultUpdateHandler.bind(name),
+            validator: undefined,
+            // Default to a warning policy.
+            unfinishedPolicy: HandlerUnfinishedPolicy.WARN_AND_ABANDON,
+          }
+        : null);
+
+    // If we don't have an entry from either source, buffer and return
+    if (entry === null) {
       this.bufferedUpdates.push(activation);
       return;
     }
 
-    const entry = this.updateHandlers.get(name) ?? {
-      // Logically, this must be defined as we got passed the conditional above
-      // pushing to the buffer. But Typescript doesn't know that so we use a
-      // non-null assertion (!).
-      handler: (...args: any[]) => this.defaultUpdateHandler!(name, ...args),
-      validator: undefined,
-      // Default to a warning policy.
-      unfinishedPolicy: HandlerUnfinishedPolicy.WARN_AND_ABANDON,
-    };
-
     const makeInput = (): UpdateInput => ({
       updateId,
       args: arrayFromPayloads(this.payloadConverter, activation.input),