Fix review comments / lints

Author: Sushisource

packages/common/src/interfaces.ts

@@ -1,5 +1,4 @@
 import type { temporal } from '@temporalio/proto';
-import { WorkflowFunctionWithOptions } from './workflow-definition-options';
 
 export type Payload = temporal.api.common.v1.IPayload;
 

packages/common/src/workflow-options.ts

@@ -251,7 +251,8 @@ export function extractWorkflowType<T extends Workflow>(
   );
 }
 
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
 export function isWorkflowFunctionWithOptions(obj: any): obj is WorkflowFunctionWithOptions<any[], any> {
-  if (obj === undefined || obj === null) return false;
+  if (obj == null) return false;
   return obj.__temporal_is_workflow_function_with_options === true;
 }

packages/test/src/deployment-versioning-v1/index.ts

@@ -1,4 +1,4 @@
-import { CancelledFailure, setHandler, condition, defineWorkflowWithOptions } from '@temporalio/workflow';
+import { setHandler, condition, defineWorkflowWithOptions } from '@temporalio/workflow';
 import { unblockSignal, versionQuery } from '../workflows';
 
 defineWorkflowWithOptions({ versioningBehavior: 'auto-upgrade' }, deploymentVersioning);

packages/test/src/deployment-versioning-v2/index.ts

@@ -1,4 +1,4 @@
-import { CancelledFailure, setHandler, condition, defineWorkflowWithOptions } from '@temporalio/workflow';
+import { setHandler, condition, defineWorkflowWithOptions } from '@temporalio/workflow';
 import { unblockSignal, versionQuery } from '../workflows';
 
 defineWorkflowWithOptions({ versioningBehavior: 'pinned' }, deploymentVersioning);

packages/test/src/deployment-versioning-v3/index.ts

@@ -1,4 +1,4 @@
-import { CancelledFailure, setHandler, condition, defineWorkflowWithOptions } from '@temporalio/workflow';
+import { setHandler, condition, defineWorkflowWithOptions } from '@temporalio/workflow';
 import { unblockSignal, versionQuery } from '../workflows';
 
 defineWorkflowWithOptions({ versioningBehavior: 'auto-upgrade' }, deploymentVersioning);

packages/test/src/test-integration-split-one.ts

@@ -733,7 +733,7 @@ test('Workflow can read WorkflowInfo', configMacro, async (t, config) => {
     historySize: res.historySize,
     startTime: res.startTime,
     runStartTime: res.runStartTime,
-    currentBuildId: res.currentBuildId,
+    currentBuildId: res.currentBuildId, // eslint-disable-line deprecation/deprecation
     // unsafe.now is a function, so doesn't make it through serialization, but .now is required, so we need to cast
     unsafe: { isReplaying: false } as UnsafeWorkflowInfo,
   });

packages/test/src/test-integration-workflows.ts

@@ -494,7 +494,7 @@ export async function buildIdTester(): Promise<void> {
   });
 
   workflow.setHandler(getBuildIdQuery, () => {
-    return workflow.workflowInfo().currentBuildId ?? '';
+    return workflow.workflowInfo().currentBuildId ?? ''; // eslint-disable-line deprecation/deprecation
   });
 
   // The unblock signal will only be sent once we are in Worker 1.1.

packages/test/src/test-sinks.ts

@@ -94,7 +94,7 @@ if (RUN_INTEGRATION_TESTS) {
     });
 
     // Capture volatile values that are hard to predict
-    const { historySize, startTime, runStartTime, currentBuildId } = recordedCalls[0].info;
+    const { historySize, startTime, runStartTime, currentBuildId } = recordedCalls[0].info; // eslint-disable-line deprecation/deprecation
     t.true(historySize > 300);
 
     const info: WorkflowInfo = {

packages/test/src/test-worker-deployment-versioning.ts

@@ -10,7 +10,6 @@ import { Client } from '@temporalio/client';
 import { toCanonicalString, WorkerDeploymentVersion } from '@temporalio/common';
 import { temporal } from '@temporalio/proto';
 import { Worker } from './helpers';
-import * as activities from './activities';
 import { makeTestFunction } from './helpers-integration';
 import { unblockSignal, versionQuery } from './workflows';
 
@@ -36,7 +35,6 @@ test('Worker deployment based versioning', async (t) => {
 
   const worker1 = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-v1'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,
@@ -51,7 +49,6 @@ test('Worker deployment based versioning', async (t) => {
 
   const worker2 = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-v2'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,
@@ -66,7 +63,6 @@ test('Worker deployment based versioning', async (t) => {
 
   const worker3 = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-v3'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,
@@ -153,7 +149,6 @@ test('Worker deployment based versioning with ramping', async (t) => {
 
   const worker1 = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-v1'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,
@@ -168,7 +163,6 @@ test('Worker deployment based versioning with ramping', async (t) => {
 
   const worker2 = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-v2'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,
@@ -260,7 +254,6 @@ test('Worker deployment with dynamic workflow on run', async (t) => {
 
   const worker = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-v1'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,
@@ -313,7 +306,6 @@ test('Workflows can use default versioning behavior', async (t) => {
 
   const worker = await Worker.create({
     workflowsPath: require.resolve('./deployment-versioning-no-annotations'),
-    activities,
     taskQueue,
     workerDeploymentOptions: {
       useWorkerVersioning: true,

packages/worker/src/utils.ts

@@ -33,7 +33,7 @@ export function convertToParentWorkflowType(
 export function convertDeploymentVersion(
   v: coresdk.common.IWorkerDeploymentVersion | null | undefined
 ): WorkerDeploymentVersion | undefined {
-  if (!v) {
+  if (v == null) {
     return undefined;
   }
 

packages/worker/src/worker-options.ts

@@ -730,8 +730,8 @@ function compileWorkerInterceptors({
 
 function addDefaultWorkerOptions(options: WorkerOptions, logger: Logger): WorkerOptionsWithDefaults {
   const {
-    buildId,
-    useVersioning,
+    buildId, // eslint-disable-line deprecation/deprecation
+    useVersioning, // eslint-disable-line deprecation/deprecation
     maxCachedWorkflows,
     showStackTraceSources,
     namespace,

packages/worker/src/worker.ts

@@ -164,7 +164,8 @@ interface WorkflowWithLogAttributes {
 }
 
 function addBuildIdIfMissing(options: CompiledWorkerOptions, bundleCode?: string): CompiledWorkerOptionsWithBuildId {
-  if (options.buildId != null) {
+  const bid = options.buildId; // eslint-disable-line deprecation/deprecation
+  if (bid != null) {
     return options as CompiledWorkerOptionsWithBuildId;
   }
   const suffix = bundleCode ? `+${crypto.createHash('sha256').update(bundleCode).digest('hex')}` : '';

packages/workflow/src/flags.ts

@@ -72,5 +72,5 @@ type AltConditionFn = (ctx: { info: WorkflowInfo }) => boolean;
 
 function buildIdSdkVersionMatches(version: RegExp): AltConditionFn {
   const regex = new RegExp(`^@temporalio/worker@(${version.source})[+]`);
-  return ({ info }) => info.currentBuildId != null && regex.test(info.currentBuildId);
+  return ({ info }) => info.currentBuildId != null && regex.test(info.currentBuildId); // eslint-disable-line deprecation/deprecation
 }

packages/workflow/src/interfaces.ts

@@ -13,7 +13,6 @@ import {
   TypedSearchAttributes,
   SearchAttributePair,
   WorkerDeploymentVersion,
-  VersioningBehavior,
 } from '@temporalio/common';
 import { SymbolBasedInstanceOfError } from '@temporalio/common/lib/type-helpers';
 import { makeProtoEnumConverters } from '@temporalio/common/lib/internal-workflow/enums-helpers';

packages/workflow/src/workflow.ts

@@ -22,6 +22,8 @@ import {
   WorkflowReturnType,
   WorkflowUpdateValidatorType,
   SearchAttributeUpdatePair,
+  WorkflowDefinitionOptions,
+  WorkflowFunctionWithOptions,
 } from '@temporalio/common';
 import {
   encodeUnifiedSearchAttributes,
@@ -31,7 +33,6 @@ import { versioningIntentToProto } from '@temporalio/common/lib/versioning-inten
 import { Duration, msOptionalToTs, msToNumber, msToTs, requiredTsToMs } from '@temporalio/common/lib/time';
 import { composeInterceptors } from '@temporalio/common/lib/interceptors';
 import { temporal } from '@temporalio/proto';
-import { WorkflowDefinitionOptions, WorkflowFunctionWithOptions } from '@temporalio/common';
 import { CancellationScope, registerSleepImplementation } from './cancellation-scope';
 import { UpdateScope } from './update-scope';
 import {