Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on server internals #585

Open
josh-berry opened this issue Jun 4, 2024 · 1 comment
Open

Don't depend on server internals #585

josh-berry opened this issue Jun 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@josh-berry
Copy link
Collaborator

As part of #584, I discovered we depend on some non-public Server APIs for dealing with task queues. We should not do this, since these APIs might change at a moment's notice.

We should scrub the codebase to remove any dependencies on Server internals.
@josh-berry josh-berry added the bug Something isn't working label Jun 4, 2024
@cretz
Copy link
Member

cretz commented Jun 4, 2024 •
edited
Loading

We should scrub the codebase to remove any dependencies on Server internals.

To clarify, remove any import of go.temporal.io/server anywhere but the devserver package (maybe)

@sync-by-unito sync-by-unito bot closed this as completed Jul 12, 2024
@josh-berry josh-berry reopened this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cretz @josh-berry